dns_signer problem

[Jim Reid]

>>>>> "Steve" == Steve WANG <xwang4 at gmu.edu> writes:

    Steve> Does somebody ever compile the "dns_signer" package that is
    Steve> in the BIND "contrib"? 

Yes.

    Steve> I tried to compiled it but found that the definition of the
    Steve> macros GETWORDorEOLN and GETWORD take 7 parameters (in
    Steve> pkg_internal_dns_parse.h), but their usages in master_parse.c and
    Steve> parse_record.c only give 6 parameters, which causes the compiling
    Steve> failed. How to fix these two problems?

The folks at TIS Labs who wrote dnssigner provided the following
patch:

------- Forwarded message
To: "Michael Milligan" <milli at acmebw.com>, bind-workers at isc.org
Subject: Re: BIND 8.2.2, trouble with dnssigner in contrib 
In-reply-to: Your message of "Wed, 20 Oct 1999 10:27:00 EDT."
             <199910201427.KAA13519 at hun.gw.tislabs.com> 
MIME-Version: 1.0
Content-ID: <13660.940431080.1 at hun.gw.tislabs.com>
Date: Wed, 20 Oct 1999 10:51:20 -0400
From: Olafur Gudmundsson <ogud at tislabs.com>

Olafur Gudmundsson writes:
 > "Michael Milligan" writes:
 >  > 
 >  > Hmm, couldn't build dnssigner.  I did a little bit of digging, but (at th
 >>is
 >  > hour) couldn't grok the logic behind the GETWORDorEOLN macro used in
 >  > parse/master_parse.c to figure out what to do.  Probably obvious to the
 >  > author.
 > 
 > Stupid me, I'm  sure I did make clean before subitting prior patch and
 > tested it but here is a fix to the fix for Monster CERT and KEY records.
 > 
 >        Olafur

Double error, I included the wrong patch in my previous message. 
Please disregard the monster patch and use this one instead.
SORRY the patch file names differed by one letter. 

      Olafur 

Index: master_parse.c
===================================================================
RCS file: /proj/cvs/isc/bind/contrib/dns_signer/parse/master_parse.c,v
retrieving revision 1.1
diff -u -r1.1 master_parse.c
--- master_parse.c	1999/01/05 03:02:30	1.1
+++ master_parse.c	1999/10/20 14:08:16
@@ -104,7 +104,7 @@
 
 	do
 	{
-		GETWORDorEOLN (ret_code, errors, first_token, *non_rr, "First word",
+		GETWORDorEOLN (ret_code, errors, first_token, sizeof(first_token), *non_rr, "First word",
 						FREE_SCRATCH_UPDATE_ERRORS_AND_RETURN_NEG1);
 
 		if (ret_code == GW_EOLN)
Index: parse_record.c
===================================================================
RCS file: /proj/cvs/isc/bind/contrib/dns_signer/parse/parse_record.c,v
retrieving revision 1.1
diff -u -r1.1 parse_record.c
--- parse_record.c	1999/01/05 03:02:33	1.1
+++ parse_record.c	1999/10/20 14:08:16
@@ -86,7 +86,7 @@
 
 	do
 	{
-		GETWORD (ret_val, errors, buffer, *non_rr,
+		GETWORD (ret_val, errors, buffer, sizeof(buffer), *non_rr,
 						"Parsing {ttl,class,type}", RETURN_NEG1);
 
 		unidentified_parsing_object = TRUE;



------- End of Forwarded message