[Fwd: suggested NOTIFY logging improvement (with patch for 8.2.2-P5)]

[Paul A Vixie]

thanks -- this will be in 8.2.3-T3B.

> Subject: suggested NOTIFY logging improvement (with patch for 8.2.2-P5)
> Date: Thu, 20 Apr 2000 13:10:44 -0500 (CDT)
> From: Scott Bertilson <scott at NTS.Umn.EDU>
> To: bind-users at isc.org
> 
>   We are running QIP and allowing it to do dynamic DNS updates
> when administrators make changes (not using it with DHCP at
> this time).  We have been having some problems with serial
> number synchronization.  In the process of debugging it,
> it seemed helpful to modify the "Sent NOTIFY" log message
> to include the zone serial number.  It is a very simple
> change (hope this is also true in BIND 9), so hope it
> can be included.
> 					Scott
> -----
> --- ns_notify.c.orig	Fri Oct 15 14:49:04 1999
> +++ ns_notify.c	Thu Apr 20 12:42:51 2000
> @@ -171,6 +171,7 @@
>  static void
>  sysnotify(const char *dname, ns_class class, ns_type type) {
>  	const char *zname, *fname;
> +	u_int32_t zserial;
>  	int nns, na, i;
>  	struct zoneinfo *zp;
>  	struct in_addr *also_addr;
> @@ -198,6 +199,7 @@
>  		return;
>  	}
>  	zname = zp->z_origin;
> +	zserial = zp->z_serial;
>  	nns = na = 0;
>  	if (zp->z_type == z_master)
>  		sysnotify_slaves(dname, zname, class, type,
> @@ -239,8 +241,8 @@
>  
>  	if (nns != 0 || na != 0)
>  		ns_info(ns_log_notify,
> -			"Sent NOTIFY for \"%s %s %s\" (%s); %d NS, %d A",
> -			dname, p_class(class), p_type(type), zname, nns, na);
> +			"Sent NOTIFY for \"%s %s %s %u\" (%s); %d NS, %d A",
> +			dname, p_class(class), p_type(type), zserial, zname, nns, na);
>  }
>  
>  static void