Stupid ns_update bug

[Matthias Urlichs]

This bug prevented me from dynamically updating A record.

Whoever did this, please consider reading the source code you're changing.
 :-(

--- test.3/bin/named/ns_update.c Sat, 28 Aug 1999 11:09:07 +0200 smurf (net_dns_bind8/k/9_ns_update. 1.7 664)
+++ test.3(w)/bin/named/ns_update.c Fri, 03 Sep 1999 14:08:36 +0200 smurf (net_dns_bind8/k/9_ns_update. 1.7 664)
@@ -1492,7 +1492,7 @@
 	case T_A:
 		if (dlen != INT32SZ)
 			return (0);
-		/*FALLTHROUGH*/
+		goto copy;
 	case T_AAAA:
 		if (dlen != NS_IN6ADDRSZ)
 			return (0);
@@ -1505,6 +1505,7 @@
 	case T_LOC:
 	case T_KEY:
 	case ns_t_cert:
+	copy:
 		if (size < dlen)
 			return (0);
 		memcpy(cp1, cp, dlen);

-- 
Matthias Urlichs  |  noris network GmbH   |   smurf at noris.de  |  ICQ: 20193661
The quote was selected randomly. Really.    |      http://www.noris.de/~smurf/
-- 
Suppose you were an idiot and suppose you were a member of Congress.
  But I repeat myself.
                -- Mark Twain (1835-1910)