BIND 8.2.3 fails to load signed zone data

[Mark.Andrews at nominum.com]

	While the first condition was bogus.  Reversing the sence of
	it does not make sence.

	Mark

Index: bin/named/db_load.c
===================================================================
RCS file: /proj/cvs/isc/bind8/src/bin/named/db_load.c,v
retrieving revision 8.111
diff -u -r8.111 db_load.c
--- db_load.c	2001/02/04 13:10:45	8.111
+++ db_load.c	2001/02/06 13:28:57
@@ -2178,8 +2178,7 @@
 	} else {
 		/* Parse and output OTTL; scan TEXP */
 		origTTL = wordtouint32(buf);
-		if (origTTL >= 0 || wordtouint32_error ||
-		    (origTTL > 0x7fffffff))
+		if (wordtouint32_error || (origTTL > 0x7fffffffU))
 			ERRTO("Original TTL value bad");
 		cp = &data[i];
 		PUTLONG(origTTL, cp);
> 
> Hi,
> 
> 	BIND 8.2.3 has trouble loading signed zone data. 
> 
> 	Using the file generated by dns_signer as an input(data) file for 
> named (8.2.3), errors like these are seen in syslog:
> 
> Feb  5 17:04:15 wais named[18488]: db.eng.signed:9: Original TTL value bad er
> ror near (86400)
> Feb  5 17:04:15 wais named[18488]: Zone "eng.sequent.com" (file db.eng.signed
> ): No default TTL ($TTL <value>) set, using SOA minimum instead
> Feb  5 17:04:15 wais named[18488]: db.eng.signed: Line 10: Unknown type: AikW
> XPjTwEbl0AtMr7jWkVGMiHsOGZER2td9ebJdWKFDzKnK.
> Feb  5 17:04:15 wais named[18488]: db.eng.signed:10: Original TTL value bad e
> rror near (AikWXPjTwEbl0AtMr7jWkVGMiHsOGZER2td9ebJdWKFDzKnK)
> 
> 		.
> 		.
> 		.
> 
> Feb  5 17:04:25 wais named[18488]: master zone "eng.sequent.com" (IN) rejecte
> d d
> ue to errors (serial 2001020501)
> 
> 	These errors are observed for all the SIG records in the file. BIND
> 8.2.2-P5/P7 does not have this problem.
> 
> 	Comparing BIND 8.2.2-P7 & BIND 8.2.3, the offending code is found to
> be in parse_sig_rr() of db_load.c [if (origTTL >= 0 || wordtouint32_error ||]
> 
> 	Applying the following diff solved the problem:
> 
--
Mark Andrews, Nominum Inc.
1 Seymour St., Dundas Valley, NSW 2117, Australia
PHONE: +61 2 9871 4742                 INTERNET: Mark.Andrews at nominum.com