ISC_MEM_TRACKLINES is accidentally quadratic, was Re: support for large batch jobs with mdig

Tony Finch dot at dotat.at
Mon Jan 23 19:57:44 UTC 2017


Tony Finch <dot at dotat.at> wrote:
>
> This accidentally quadratic performance is to do with ISC_MEM_TRACKLINES -
> turn that off and freeing is instant! But it needs a fix...

The other fix is to remove what looks (from the weird indentation) like
some stray debugging code that got committed by accident.

And with mdig unhobbled, it manages to process the whole top-1m list in
less than 34s, nearly 30kqps. Not bad!

---
 bin/tools/mdig.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/bin/tools/mdig.c b/bin/tools/mdig.c
index 034bf91..0839845 100644
--- a/bin/tools/mdig.c
+++ b/bin/tools/mdig.c
@@ -1901,7 +1901,6 @@ main(int argc, char *argv[]) {
 		fatal("could not find either IPv4 or IPv6");

 	mctx = NULL;
-isc_mem_debugging = ISC_MEM_DEBUGRECORD;
 	RUNCHECK(isc_mem_create(0, 0, &mctx));

 	lctx = NULL;
-- 
2.10.1.445.g3cdd5d1


More information about the bind-workers mailing list