On Thu, Nov 03, 2005 at 09:08:21PM -0500, Danny Mayer wrote: > > diff --git a/net/core/datagram.c b/net/core/datagram.c > > --- a/net/core/datagram.c > > +++ b/net/core/datagram.c > > @@ -213,6 +213,10 @@ int skb_copy_datagram_iovec(const struct > > { > > int i, err, fraglen, end = 0; > > struct sk_buff *next = skb_shinfo(skb)->frag_list; > > + > > + if (!len) > > + return 0; > > + > > next_skb: > > fraglen = skb_headlen(skb); > > i = -1; > > If len is an integer signed or unsigned, that's improper code. I can't > imagine why it would not be written as: > > if (len <= 0) > return 0; > You'll need to ask Herbert Xu about it for he wrote this patch. All i know is that it fixes this kernel bug and that this integer in particular is very unlikely to be < 0 as it represents the udp packets payload length, but i can see your point here. > I would stay away from any software and O/S that considered good coding > practice. Then this must be why you are using: User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) scnr - that was just too good a draft. ;) Stefan -- Any problem in computer science can be solved with another layer of indirection. But that usually will create another problem. - David Wheeler (1927 - 2004)