[svn] commit: r1798 - /trunk/src/lib/dns/tests/rdata_ds_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Apr 27 03:06:58 UTC 2010


Author: jinmei
Date: Tue Apr 27 03:06:58 2010
New Revision: 1798

Log:
use the DISABLED prefix for a failed test (instead of 'if 0'ing it)

trivial change, skipping review.  build/test okay.

Modified:
    trunk/src/lib/dns/tests/rdata_ds_unittest.cc

Modified: trunk/src/lib/dns/tests/rdata_ds_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_ds_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_ds_unittest.cc Tue Apr 27 03:06:58 2010
@@ -52,13 +52,15 @@
     EXPECT_THROW(const generic::DS ds2("11111 5 22222 BEEF"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("11111 5 2"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("GARBAGE IN"), InvalidRdataText);
+}
 
-#if 0              // this test currently fails
+// this test currently fails; we must fix it, and then migrate the test to
+// badText_DS
+TEST_F(Rdata_DS_Test, DISABLED_badText_DS) {
     // no space between the digest type and the digest.
     EXPECT_THROW(const generic::DS ds2(
                      "12892 5 2F1E184C0E1D615D20EB3C223ACED3B03C773DD952D"
                      "5F0EB5C777586DE18DA6B5"), InvalidRdataText);
-#endif
 }
 
 TEST_F(Rdata_DS_Test, createFromWire_DS) {




More information about the bind10-changes mailing list