[svn] commit: r2691 - /trunk/src/lib/bench/tests/benchmark_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Aug 10 16:29:09 UTC 2010


Author: jinmei
Date: Tue Aug 10 16:29:09 2010
New Revision: 2691

Log:
a heuristic parameter adjustment for BenchMarkTest.run: the previous margin
(20%) didn't always work for a (seemingly) slow machine, so raise it to 25%.

should be quite trivial, and skipping formal review.  discussed on jabber.

Modified:
    trunk/src/lib/bench/tests/benchmark_unittest.cc

Modified: trunk/src/lib/bench/tests/benchmark_unittest.cc
==============================================================================
--- trunk/src/lib/bench/tests/benchmark_unittest.cc (original)
+++ trunk/src/lib/bench/tests/benchmark_unittest.cc Tue Aug 10 16:29:09 2010
@@ -70,9 +70,9 @@
     const int sub_iterations = 23;
     const int sleep_time = 50000; // will sleep for 50ms
     // we cannot expect particular accuracy on the measured duration, so
-    // we'll include some conservative margin (20%) and perform range
+    // we'll include some conservative margin (25%) and perform range
     // comparison below.
-    const int duration_margin = 10000; // 10ms
+    const int duration_margin = 12500; // 12.5ms
     const int ONE_MILLION = 1000000;
 
     // Prerequisite check: since the tests in this case may depend on subtle




More information about the bind10-changes mailing list