[svn] commit: r4009 - in /trunk/src/lib/asiolink: asiolink.h internal/tcpdns.h

BIND 10 source code commits bind10-changes at lists.isc.org
Sat Dec 25 20:03:20 UTC 2010


Author: jinmei
Date: Sat Dec 25 20:03:19 2010
New Revision: 4009

Log:
trivial cleanups: removed some unnecessary or meaningless 'inline' declarations:
 - member functions with a definition will automatically be inlined
 - virtual functions cannot be inlined anyway
believing trivial, skip review.

Modified:
    trunk/src/lib/asiolink/asiolink.h
    trunk/src/lib/asiolink/internal/tcpdns.h

Modified: trunk/src/lib/asiolink/asiolink.h
==============================================================================
--- trunk/src/lib/asiolink/asiolink.h (original)
+++ trunk/src/lib/asiolink/asiolink.h Sat Dec 25 20:03:19 2010
@@ -300,13 +300,13 @@
     ///
     /// \param done If true, this signals the system there is an answer
     ///             to return.
-    virtual inline void resume(const bool done) { self_->resume(done); }
+    virtual void resume(const bool done) { self_->resume(done); }
 
     /// \brief Indicate whether the server is able to send an answer
     /// to a query.
     /// 
     /// This is presently used only for testing purposes.
-    virtual inline bool hasAnswer() { return (self_->hasAnswer()); }
+    virtual bool hasAnswer() { return (self_->hasAnswer()); }
 
     /// \brief Returns the current value of the 'coroutine' object
     ///
@@ -316,7 +316,7 @@
     /// about its current state.
     ///
     /// \return The value of the 'coroutine' object
-    virtual inline int value() { return (self_->value()); }
+    virtual int value() { return (self_->value()); }
 
     /// \brief Returns a pointer to a clone of this DNSServer object.
     ///
@@ -326,7 +326,7 @@
     /// that the underlying object is also correctly copied.
     ///
     /// \return A deep copy of this DNSServer object
-    virtual inline DNSServer* clone() { return (self_->clone()); }
+    virtual DNSServer* clone() { return (self_->clone()); }
     //@}
 
 protected:
@@ -349,7 +349,7 @@
     class AsyncLookup {
     public:
         AsyncLookup(T& caller) : caller_(caller) {}
-        inline void operator()() { caller_.asyncLookup(); }
+        void operator()() { caller_.asyncLookup(); }
     private:
         T caller_;
     };
@@ -361,7 +361,7 @@
     /// the details of the query and a pointer back to the current
     /// server object.  It is called asynchronously via the AsyncLookup
     /// handler class.
-    virtual inline void asyncLookup() { self_->asyncLookup(); }
+    virtual void asyncLookup() { self_->asyncLookup(); }
 
 private:
     DNSServer* self_;

Modified: trunk/src/lib/asiolink/internal/tcpdns.h
==============================================================================
--- trunk/src/lib/asiolink/internal/tcpdns.h (original)
+++ trunk/src/lib/asiolink/internal/tcpdns.h Sat Dec 25 20:03:19 2010
@@ -79,25 +79,25 @@
     ~TCPEndpoint() { delete asio_endpoint_placeholder_; }
     //@}
 
-    inline IOAddress getAddress() const {
+    IOAddress getAddress() const {
         return (asio_endpoint_.address());
     }
 
-    inline uint16_t getPort() const {
+    uint16_t getPort() const {
         return (asio_endpoint_.port());
     }
 
-    inline short getProtocol() const {
+    short getProtocol() const {
         return (asio_endpoint_.protocol().protocol());
     }
 
-    inline short getFamily() const {
+    short getFamily() const {
         return (asio_endpoint_.protocol().family());
     }
 
     // This is not part of the exosed IOEndpoint API but allows
     // direct access to the ASIO implementation of the endpoint
-    inline const asio::ip::tcp::endpoint& getASIOEndpoint() const {
+    const asio::ip::tcp::endpoint& getASIOEndpoint() const {
         return (asio_endpoint_);
     }
 
@@ -123,8 +123,8 @@
     /// \param socket The ASIO representation of the TCP socket.
     TCPSocket(asio::ip::tcp::socket& socket) : socket_(socket) {}
 
-    inline int getNative() const { return (socket_.native()); }
-    inline int getProtocol() const { return (IPPROTO_TCP); }
+    int getNative() const { return (socket_.native()); }
+    int getProtocol() const { return (IPPROTO_TCP); }
 
 private:
     asio::ip::tcp::socket& socket_;




More information about the bind10-changes mailing list