[svn] commit: r792 - in /branches/jinmei-dnsrdata2/src/lib/dns/cpp: name.h tests/name_unittest.cc
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Feb 10 23:20:52 UTC 2010
Author: jinmei
Date: Wed Feb 10 23:20:51 2010
New Revision: 792
Log:
merged from trunk
Modified:
branches/jinmei-dnsrdata2/src/lib/dns/cpp/name.h
branches/jinmei-dnsrdata2/src/lib/dns/cpp/tests/name_unittest.cc
Modified: branches/jinmei-dnsrdata2/src/lib/dns/cpp/name.h
==============================================================================
--- branches/jinmei-dnsrdata2/src/lib/dns/cpp/name.h (original)
+++ branches/jinmei-dnsrdata2/src/lib/dns/cpp/name.h Wed Feb 10 23:20:51 2010
@@ -261,7 +261,11 @@
/// \param buffer A buffer storing the wire format data.
/// \param downcase Whether to convert upper case alphabets to lower case.
explicit Name(InputBuffer& buffer, bool downcase = false);
- //@}
+ ///
+ /// We use the default copy constructor intentionally.
+ //@}
+ /// We use the default copy assignment operator intentionally.
+ ///
///
/// \name Getter Methods
Modified: branches/jinmei-dnsrdata2/src/lib/dns/cpp/tests/name_unittest.cc
==============================================================================
--- branches/jinmei-dnsrdata2/src/lib/dns/cpp/tests/name_unittest.cc (original)
+++ branches/jinmei-dnsrdata2/src/lib/dns/cpp/tests/name_unittest.cc Wed Feb 10 23:20:51 2010
@@ -266,6 +266,36 @@
25).getLabelCount());
}
+TEST_F(NameTest, copyConstruct)
+{
+ Name copy(example_name);
+ EXPECT_EQ(copy, example_name);
+
+ // Check the copied data is valid even after the original is deleted
+ Name* copy2 = new Name(example_name);
+ Name copy3(*copy2);
+ delete copy2;
+ EXPECT_EQ(copy3, example_name);
+}
+
+TEST_F(NameTest, assignment)
+{
+ Name copy(".");
+ copy = example_name;
+ EXPECT_EQ(copy, example_name);
+
+ // Check if the copied data is valid even after the original is deleted
+ Name* copy2 = new Name(example_name);
+ Name copy3(".");
+ copy3 = *copy2;
+ delete copy2;
+ EXPECT_EQ(copy3, example_name);
+
+ // Self assignment
+ copy = copy;
+ EXPECT_EQ(copy, example_name);
+}
+
TEST_F(NameTest, toText)
{
// tests derived from BIND9
More information about the bind10-changes
mailing list