[svn] commit: r1006 - /trunk/src/lib/dns/cpp/tests/rrsetlist_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Feb 26 19:29:33 UTC 2010


Author: jinmei
Date: Fri Feb 26 19:29:32 2010
New Revision: 1006

Log:
preferred EXPECT_EQ(a,b) to EXPECT_TRUE(a==b) because on failure we can see
the vlaues of a and b

Modified:
    trunk/src/lib/dns/cpp/tests/rrsetlist_unittest.cc

Modified: trunk/src/lib/dns/cpp/tests/rrsetlist_unittest.cc
==============================================================================
--- trunk/src/lib/dns/cpp/tests/rrsetlist_unittest.cc (original)
+++ trunk/src/lib/dns/cpp/tests/rrsetlist_unittest.cc Fri Feb 26 19:29:32 2010
@@ -107,19 +107,19 @@
     RRsetPtr p;
 
     p = list[RRType::CNAME()];
-    EXPECT_TRUE(p->getType() == RRType::CNAME());
+    EXPECT_EQ(p->getType(), RRType::CNAME());
 
     p = list[RRType::AAAA()];
-    EXPECT_TRUE(p->getType() == RRType::AAAA());
+    EXPECT_EQ(p->getType(), RRType::AAAA());
 
     p = list[RRType::NS()];
-    EXPECT_TRUE(p->getType() == RRType::NS());
+    EXPECT_EQ(p->getType(), RRType::NS());
 
     p = list[RRType::A()];
-    EXPECT_TRUE(p->getType() == RRType::A());
+    EXPECT_EQ(p->getType(), RRType::A());
 
     p = list[RRType::SOA()];
-    EXPECT_TRUE(p->getType() == RRType::SOA());
+    EXPECT_EQ(p->getType(), RRType::SOA());
 }
 
 TEST_F(RRsetListTest, findRRset) {




More information about the bind10-changes mailing list