[svn] commit: r1027 - /trunk/src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Sat Feb 27 04:09:13 UTC 2010


Author: jinmei
Date: Sat Feb 27 04:09:13 2010
New Revision: 1027

Log:
added some more pathological cases to badText.
actually I'm not sure if these should be rejected or accepted.

Modified:
    trunk/src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc

Modified: trunk/src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc
==============================================================================
--- trunk/src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc (original)
+++ trunk/src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc Sat Feb 27 04:09:13 2010
@@ -73,6 +73,13 @@
                  InvalidRdataText);
     EXPECT_THROW(generic::DNSKEY("257 3 5 BAAAAAAAAAAAD"),
                  BadBase64String);
+    // Should this be allowed?
+//     EXPECT_THROW(generic::DNSKEY("257 3 5BEAAEFTd"),
+//                  InvalidRdataText);
+    // How about this?  It's even more confusing for the parser because
+    // it could be ambiguous '51 EAAA' vs '5 1EAA..'
+//     EXPECT_THROW(generic::DNSKEY("257 3 51EAAEFTd"),
+//                  InvalidRdataText);
 }
 
 TEST_F(Rdata_DNSKEY_Test, toWireRenderer)




More information about the bind10-changes mailing list