[svn] commit: r465 - in /branches/jinmei-dnsrrparams/src/lib/dns/cpp: rrparamregistry.cc rrparamregistry_unittest.cc

[BIND 10 source code commits]

Author: jinmei
Date: Thu Jan 14 00:26:02 2010
New Revision: 465

Log:
- added some more tests for wider coverage
- use assertion for conditions that must be met

Modified:
    branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry.cc
    branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry_unittest.cc

Modified: branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry.cc
==============================================================================
--- branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry.cc (original)
+++ branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry.cc Thu Jan 14 00:26:02 2010
@@ -14,6 +14,7 @@
 
 // $Id$
 
+#include <cassert>
 #include <algorithm>
 #include <cctype>
 #include <functional>
@@ -213,9 +214,7 @@
 bool
 caseStringEqual(const string& s1, const string& s2, size_t n)
 {
-    if (s1.size() < n || s2.size() < n) {
-        return (false);
-    }
+    assert(s1.size() >= n && s2.size() >= n);
 
     return (mismatch(s1.begin(), s1.begin() + n, s2.begin(), CICharEqual).first
             == s1.begin() + n);

Modified: branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry_unittest.cc
==============================================================================
--- branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry_unittest.cc (original)
+++ branches/jinmei-dnsrrparams/src/lib/dns/cpp/rrparamregistry_unittest.cc Thu Jan 14 00:26:02 2010
@@ -62,10 +62,17 @@
     EXPECT_EQ(65533, RRClass("TESTCLASS").getCode());
     EXPECT_EQ(65534, RRType("TESTTYPE").getCode());
 
+    // the first removal attempt should succeed
+    EXPECT_TRUE(RRParamRegistry::getRegistry().removeType(65534));
+    // then toText() should treat it as an "unknown" 
+    EXPECT_EQ(test_type_unknown_str, RRType(test_type_code).toText());
+    // attempt of removing non-existent mapping should result in 'false'
+    EXPECT_FALSE(RRParamRegistry::getRegistry().removeType(65534));
+
+    // same set of tests for RR class.
     EXPECT_TRUE(RRParamRegistry::getRegistry().removeClass(65533));
     EXPECT_EQ(test_class_unknown_str, RRClass(test_class_code).toText());
-    EXPECT_TRUE(RRParamRegistry::getRegistry().removeType(65534));
-    EXPECT_EQ(test_type_unknown_str, RRType(test_type_code).toText());
+    EXPECT_FALSE(RRParamRegistry::getRegistry().removeClass(65533));
 }
 
 TEST_F(RRParamRegistryTest, addError)