[svn] commit: r582 - in /branches/parkinglot/src: bin/msgq/msgq.py lib/cc/python/ISC/CC/Message.py

[BIND 10 source code commits]

Author: mgraff
Date: Thu Jan 28 04:09:37 2010
New Revision: 582

Log:
more review comments

Modified:
    branches/parkinglot/src/bin/msgq/msgq.py
    branches/parkinglot/src/lib/cc/python/ISC/CC/Message.py

Modified: branches/parkinglot/src/bin/msgq/msgq.py
==============================================================================
--- branches/parkinglot/src/bin/msgq/msgq.py (original)
+++ branches/parkinglot/src/bin/msgq/msgq.py Thu Jan 28 04:09:37 2010
@@ -39,13 +39,13 @@
         """Remove the socket from the one specific subscription."""
         target = ( group, instance )
         if target in self.subscriptions:
-            while socket in self.subscriptions[target]:
+            if socket in self.subscriptions[target]:
                 self.subscriptions[target].remove(socket)
 
     def unsubscribe_all(self, socket):
         """Remove the socket from all subscriptions."""
         for socklist in self.subscriptions.values():
-            while socket in socklist:
+            if socket in socklist:
                 socklist.remove(socket)
 
     def find_sub(self, group, instance):

Modified: branches/parkinglot/src/lib/cc/python/ISC/CC/Message.py
==============================================================================
--- branches/parkinglot/src/lib/cc/python/ISC/CC/Message.py (original)
+++ branches/parkinglot/src/lib/cc/python/ISC/CC/Message.py Thu Jan 28 04:09:37 2010
@@ -62,7 +62,7 @@
     elif length < 0x00010000:
         return(struct.pack(">B H", datatype | _ITEM_LENGTH_16, length) + data)
     else:
-        return(struct.pack(">B I", datatype, length) + data)
+        return(struct.pack(">B I", datatype | _ITEM_LENGTH_32, length) + data)
 
 def _pack_utf8(item):
     """Pack a string (utf-8) and its type/length prefix."""