[svn] commit: r2604 - in /trunk/src/lib/dns/python: message_python.cc rrclass_python.cc rrttl_python.cc rrtype_python.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Sun Jul 25 10:51:38 UTC 2010


Author: jinmei
Date: Sun Jul 25 10:51:38 2010
New Revision: 2604

Log:
removed redundant null checks before delete.
should be trivial enough, skipping review.

Modified:
    trunk/src/lib/dns/python/message_python.cc
    trunk/src/lib/dns/python/rrclass_python.cc
    trunk/src/lib/dns/python/rrttl_python.cc
    trunk/src/lib/dns/python/rrtype_python.cc

Modified: trunk/src/lib/dns/python/message_python.cc
==============================================================================
--- trunk/src/lib/dns/python/message_python.cc (original)
+++ trunk/src/lib/dns/python/message_python.cc Sun Jul 25 10:51:38 2010
@@ -1192,8 +1192,7 @@
 
 static void
 Message_destroy(s_Message* self) {
-    if (self->message != NULL)
-        delete self->message;
+    delete self->message;
     self->message = NULL;
     Py_TYPE(self)->tp_free(self);
 }

Modified: trunk/src/lib/dns/python/rrclass_python.cc
==============================================================================
--- trunk/src/lib/dns/python/rrclass_python.cc (original)
+++ trunk/src/lib/dns/python/rrclass_python.cc Sun Jul 25 10:51:38 2010
@@ -201,8 +201,7 @@
 
 static void
 RRClass_destroy(s_RRClass* self) {
-    if (self->rrclass != NULL)
-        delete self->rrclass;
+    delete self->rrclass;
     self->rrclass = NULL;
     Py_TYPE(self)->tp_free(self);
 }

Modified: trunk/src/lib/dns/python/rrttl_python.cc
==============================================================================
--- trunk/src/lib/dns/python/rrttl_python.cc (original)
+++ trunk/src/lib/dns/python/rrttl_python.cc Sun Jul 25 10:51:38 2010
@@ -199,8 +199,7 @@
 
 static void
 RRTTL_destroy(s_RRTTL* self) {
-    if (self->rrttl != NULL)
-        delete self->rrttl;
+    delete self->rrttl;
     self->rrttl = NULL;
     Py_TYPE(self)->tp_free(self);
 }

Modified: trunk/src/lib/dns/python/rrtype_python.cc
==============================================================================
--- trunk/src/lib/dns/python/rrtype_python.cc (original)
+++ trunk/src/lib/dns/python/rrtype_python.cc Sun Jul 25 10:51:38 2010
@@ -239,8 +239,7 @@
 
 static void
 RRType_destroy(s_RRType* self) {
-    if (self->rrtype != NULL)
-        delete self->rrtype;
+    delete self->rrtype;
     self->rrtype = NULL;
     Py_TYPE(self)->tp_free(self);
 }




More information about the bind10-changes mailing list