[svn] commit: r2042 - in /trunk/src/lib/datasrc/tests: sqlite3_unittest.cc static_unittest.cc

[BIND 10 source code commits]

Author: jinmei
Date: Wed Jun  2 06:05:56 2010
New Revision: 2042

Log:
added notes about r2040 and r2041.

Modified:
    trunk/src/lib/datasrc/tests/sqlite3_unittest.cc
    trunk/src/lib/datasrc/tests/static_unittest.cc

Modified: trunk/src/lib/datasrc/tests/sqlite3_unittest.cc
==============================================================================
--- trunk/src/lib/datasrc/tests/sqlite3_unittest.cc (original)
+++ trunk/src/lib/datasrc/tests/sqlite3_unittest.cc Wed Jun  2 06:05:56 2010
@@ -376,6 +376,8 @@
 
     NameMatch name_match(www_name);
     data_source.findClosestEnclosure(name_match, rrclass);
+    // XXX: some deviant compilers seem to fail to recognize a NULL as a
+    // pointer type.  This explicit cast works around such compilers.
     EXPECT_EQ(static_cast<void*>(NULL), name_match.closestName());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.bestDataSrc());
 }

Modified: trunk/src/lib/datasrc/tests/static_unittest.cc
==============================================================================
--- trunk/src/lib/datasrc/tests/static_unittest.cc (original)
+++ trunk/src/lib/datasrc/tests/static_unittest.cc Wed Jun  2 06:05:56 2010
@@ -214,6 +214,7 @@
 TEST_F(StaticDataSourceTest, findClosestEnclosureForVersionClassMismatch) {
     NameMatch name_match(version_name);
     data_source.findClosestEnclosure(name_match, RRClass::IN());
+    // XXX: see sqlite3_unittest.cc about the cast.
     EXPECT_EQ(static_cast<void*>(NULL), name_match.closestName());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.bestDataSrc());
 }