[svn] commit: r2246 - /branches/trac192/src/lib/datasrc/tests/cache_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jun 23 19:06:13 UTC 2010


Author: each
Date: Wed Jun 23 19:06:13 2010
New Revision: 2246

Log:
Eliminated hard-coded flags in cache unittest.

Modified:
    branches/trac192/src/lib/datasrc/tests/cache_unittest.cc

Modified: branches/trac192/src/lib/datasrc/tests/cache_unittest.cc
==============================================================================
--- branches/trac192/src/lib/datasrc/tests/cache_unittest.cc (original)
+++ branches/trac192/src/lib/datasrc/tests/cache_unittest.cc Wed Jun 23 19:06:13 2010
@@ -25,6 +25,7 @@
 #include <dns/rrset.h>
 
 #include <datasrc/cache.h>
+#include <datasrc/data_source.h>
 
 #include <gtest/gtest.h>
 
@@ -144,17 +145,17 @@
     hit = cache.retrieve(test_name, RRClass::IN(), RRType::A(), r, f);
     EXPECT_TRUE(hit);
     EXPECT_TRUE(r);
-    EXPECT_EQ(1, f);
-
-    hit = cache.retrieve(test_nsname, RRClass::IN(), RRType::NS(), r, f);
-    EXPECT_TRUE(hit);
-    EXPECT_TRUE(r);
-    EXPECT_EQ(2, f);
-
-    hit = cache.retrieve(test_ch, RRClass::CH(), RRType::TXT(), r, f);
-    EXPECT_TRUE(hit);
-    EXPECT_TRUE(r);
-    EXPECT_EQ(4, f);
+    EXPECT_EQ(DataSrc::REFERRAL, f);
+
+    hit = cache.retrieve(test_nsname, RRClass::IN(), RRType::NS(), r, f);
+    EXPECT_TRUE(hit);
+    EXPECT_TRUE(r);
+    EXPECT_EQ(DataSrc::CNAME_FOUND, f);
+
+    hit = cache.retrieve(test_ch, RRClass::CH(), RRType::TXT(), r, f);
+    EXPECT_TRUE(hit);
+    EXPECT_TRUE(r);
+    EXPECT_EQ(DataSrc::NAME_NOT_FOUND, f);
 }
 
 TEST_F(CacheTest, retrieveFail) {
@@ -245,7 +246,7 @@
 
     EXPECT_TRUE(hit);
     EXPECT_FALSE(r);
-    EXPECT_EQ(8, f);
+    EXPECT_EQ(DataSrc::TYPE_NOT_FOUND, f);
 }
 
 TEST_F(CacheTest, overwrite) {
@@ -270,7 +271,7 @@
     hit = cache.retrieve(test_name, RRClass::IN(), RRType::A(), r, f);
     EXPECT_TRUE(hit);
     EXPECT_FALSE(r);
-    EXPECT_EQ(1, f);
+    EXPECT_EQ(DataSrc::REFERRAL, f);
 }
 
 TEST_F(CacheTest, reduceSlots) {




More information about the bind10-changes mailing list