[svn] commit: r2334 - /branches/trac221/src/bin/auth/auth_srv.cc

[BIND 10 source code commits]

Author: jinmei
Date: Tue Jun 29 22:33:54 2010
New Revision: 2334

Log:
added comment about why we don't return SERVFAIL due to an internal error in handling notify

Modified:
    branches/trac221/src/bin/auth/auth_srv.cc

Modified: branches/trac221/src/bin/auth/auth_srv.cc
==============================================================================
--- branches/trac221/src/bin/auth/auth_srv.cc (original)
+++ branches/trac221/src/bin/auth/auth_srv.cc Tue Jun 29 22:33:54 2010
@@ -406,6 +406,11 @@
 
     // TODO check with the conf-mgr whether current server is the auth of the
     // zone
+
+    // In the code that follows, we simply ignore the notify if any internal
+    // error happens rather than returning (e.g.) SERVFAIL.  RFC 1996 is
+    // silent about such cases, but there doesn't seem to be anything we can
+    // improve at the primary server side by sending an error anyway.
     if (!is_notify_session_established_) {
         try {
             session_with_xfrin_.establish(NULL);