[svn] commit: r2348 - in /branches/trac69/src/lib/dns: message.cc message.h
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Jun 30 15:24:54 UTC 2010
Author: each
Date: Wed Jun 30 15:24:54 2010
New Revision: 2348
Log:
updated comments, per review
Modified:
branches/trac69/src/lib/dns/message.cc
branches/trac69/src/lib/dns/message.h
Modified: branches/trac69/src/lib/dns/message.cc
==============================================================================
--- branches/trac69/src/lib/dns/message.cc (original)
+++ branches/trac69/src/lib/dns/message.cc Wed Jun 30 15:24:54 2010
@@ -371,7 +371,6 @@
"addRRset performed in non-render mode");
}
- // Note: should check duplicate (TBD)
impl_->rrsets_[sectionCodeToId(section)].push_back(rrset);
impl_->counts_[section.getCode()] += rrset->getRdataCount();
Modified: branches/trac69/src/lib/dns/message.h
==============================================================================
--- branches/trac69/src/lib/dns/message.h (original)
+++ branches/trac69/src/lib/dns/message.h Wed Jun 30 15:24:54 2010
@@ -739,6 +739,10 @@
/// \c rrset. This interface design needs to be revisited later.
///
/// Only allowed in the \c RENDER mode.
+ ///
+ /// Note that addRRset() does not currently check for duplicate
+ /// data before inserting RRsets. The caller is responsible for
+ /// checking for these (see hasRRset() below).
void addRRset(const Section& section, RRsetPtr rrset, bool sign = false);
/// \brief Determine whether the given section already has an RRset
More information about the bind10-changes
mailing list