[svn] commit: r2368 - in /branches/trac192/src/bin/auth: auth_srv.cc auth_srv.h tests/auth_srv_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jun 30 19:41:26 UTC 2010


Author: jinmei
Date: Wed Jun 30 19:41:26 2010
New Revision: 2368

Log:
minor proposed changes on style:
  avoid relying on default parameter
  fold a long line

Modified:
    branches/trac192/src/bin/auth/auth_srv.cc
    branches/trac192/src/bin/auth/auth_srv.h
    branches/trac192/src/bin/auth/tests/auth_srv_unittest.cc

Modified: branches/trac192/src/bin/auth/auth_srv.cc
==============================================================================
--- branches/trac192/src/bin/auth/auth_srv.cc (original)
+++ branches/trac192/src/bin/auth/auth_srv.cc Wed Jun 30 19:41:26 2010
@@ -81,7 +81,8 @@
     isc::datasrc::HotCache cache_;
 };
 
-AuthSrvImpl::AuthSrvImpl(const bool use_cache) : cs_(NULL), verbose_mode_(false)
+AuthSrvImpl::AuthSrvImpl(const bool use_cache) :
+    cs_(NULL), verbose_mode_(false)
 {
     // cur_datasrc_ is automatically initialized by the default constructor,
     // effectively being an empty (sqlite) data source.  once ccsession is up

Modified: branches/trac192/src/bin/auth/auth_srv.h
==============================================================================
--- branches/trac192/src/bin/auth/auth_srv.h (original)
+++ branches/trac192/src/bin/auth/auth_srv.h Wed Jun 30 19:41:26 2010
@@ -43,7 +43,7 @@
     AuthSrv(const AuthSrv& source);
     AuthSrv& operator=(const AuthSrv& source);
 public:
-    explicit AuthSrv(const bool use_cache = true);
+    explicit AuthSrv(const bool use_cache);
     ~AuthSrv();
     //@}
     /// \return \c true if the \message contains a response to be returned;

Modified: branches/trac192/src/bin/auth/tests/auth_srv_unittest.cc
==============================================================================
--- branches/trac192/src/bin/auth/tests/auth_srv_unittest.cc (original)
+++ branches/trac192/src/bin/auth/tests/auth_srv_unittest.cc Wed Jun 30 19:41:26 2010
@@ -44,7 +44,7 @@
 
 class AuthSrvTest : public ::testing::Test {
 protected:
-    AuthSrvTest() : request_message(Message::RENDER),
+    AuthSrvTest() : server(true), request_message(Message::RENDER),
                     parse_message(Message::PARSE), default_qid(0x1035),
                     opcode(Opcode(Opcode::QUERY())), qname("www.example.com"),
                     qclass(RRClass::IN()), qtype(RRType::A()), ibuffer(NULL),




More information about the bind10-changes mailing list