[svn] commit: r1095 - in /trunk/src/lib/dns/cpp/rdata/generic: dnskey_48.cc ds_43.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Mar 3 22:30:23 UTC 2010


Author: jinmei
Date: Wed Mar  3 22:30:23 2010
New Revision: 1095

Log:
avoid byte-by-byte copy

Modified:
    trunk/src/lib/dns/cpp/rdata/generic/dnskey_48.cc
    trunk/src/lib/dns/cpp/rdata/generic/ds_43.cc

Modified: trunk/src/lib/dns/cpp/rdata/generic/dnskey_48.cc
==============================================================================
--- trunk/src/lib/dns/cpp/rdata/generic/dnskey_48.cc (original)
+++ trunk/src/lib/dns/cpp/rdata/generic/dnskey_48.cc Wed Mar  3 22:30:23 2010
@@ -90,12 +90,10 @@
     uint16_t flags = buffer.readUint16();
     uint16_t protocol = buffer.readUint8();
     uint16_t algorithm = buffer.readUint8();
-    vector<uint8_t> keydata;
 
     rdata_len -= 4;
-    for (int i = 0; i < rdata_len; i++) {
-        keydata.push_back(buffer.readUint8());
-    }
+    vector<uint8_t> keydata(rdata_len);
+    buffer.readData(&keydata[0], rdata_len);
 
     impl_ = new DNSKEYImpl(flags, protocol, algorithm, keydata);
 }

Modified: trunk/src/lib/dns/cpp/rdata/generic/ds_43.cc
==============================================================================
--- trunk/src/lib/dns/cpp/rdata/generic/ds_43.cc (original)
+++ trunk/src/lib/dns/cpp/rdata/generic/ds_43.cc Wed Mar  3 22:30:23 2010
@@ -85,12 +85,10 @@
     uint16_t tag = buffer.readUint16();
     uint16_t algorithm = buffer.readUint8();
     uint16_t digest_type = buffer.readUint8();
-    vector<uint8_t> digest;
 
     rdata_len -= 4;
-    for (int i = 0; i < rdata_len; i++) {
-        digest.push_back(buffer.readUint8());
-    }
+    vector<uint8_t> digest(rdata_len);
+    buffer.readData(&digest[0], rdata_len);
 
     impl_ = new DSImpl(tag, algorithm, digest_type, digest);
 }




More information about the bind10-changes mailing list