[svn] commit: r1107 - /trunk/src/lib/auth/cpp/query.h
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Mar 4 01:04:34 UTC 2010
Author: jinmei
Date: Thu Mar 4 01:04:34 2010
New Revision: 1107
Log:
added clarification comments on constness
Modified:
trunk/src/lib/auth/cpp/query.h
Modified: trunk/src/lib/auth/cpp/query.h
==============================================================================
--- trunk/src/lib/auth/cpp/query.h (original)
+++ trunk/src/lib/auth/cpp/query.h Thu Mar 4 01:04:34 2010
@@ -183,7 +183,13 @@
const isc::dns::RRClass& qclass() const { return *qclass_; }
const isc::dns::RRType& qtype() const { return *qtype_; }
- isc::dns::Message& message() const { return *message_; }
+ // Note: these can't be constant member functions because they expose
+ // writable 'handles' of internal member variables. It's questionable
+ // whether we need these accessors in the first place because the
+ // corresponding members are public (which itself is not a good practice
+ // but it's a different topic), but at the moment we keep them.
+ // We should definitely revisit the design later.
+ isc::dns::Message& message() { return *message_; }
QueryTaskQueue& tasks() { return querytasks_; }
Status status() const { return status_; }
More information about the bind10-changes
mailing list