[svn] commit: r1310 - in /trunk/src/lib/auth: data_source.h static_datasrc.h

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Mar 11 00:27:59 UTC 2010


Author: jinmei
Date: Thu Mar 11 00:27:59 2010
New Revision: 1310

Log:
clarified some function parameters are intionally unused

Modified:
    trunk/src/lib/auth/data_source.h
    trunk/src/lib/auth/static_datasrc.h

Modified: trunk/src/lib/auth/data_source.h
==============================================================================
--- trunk/src/lib/auth/data_source.h (original)
+++ trunk/src/lib/auth/data_source.h Thu Mar 11 00:27:59 2010
@@ -16,6 +16,8 @@
 
 #ifndef __DATA_SOURCE_H
 #define __DATA_SOURCE_H
+
+#include "config.h"
 
 #include <stdint.h>
 
@@ -183,7 +185,8 @@
     void setClass(const isc::dns::RRClass& c) { rrclass = c; }
 
     Result init() { return NOT_IMPLEMENTED; }
-    Result init(const isc::data::ElementPtr config) { return NOT_IMPLEMENTED; }
+    Result init(const isc::data::ElementPtr config UNUSED_PARAM)
+    { return NOT_IMPLEMENTED; }
     Result close() { return NOT_IMPLEMENTED; }
 
     virtual Result findRRset(const Query& q,
@@ -261,52 +264,62 @@
     // to get a pointer to the best concrete data source for the specified
     // zone, then send all queries directly to that data source.
 
-    Result findRRset(const Query& q, const isc::dns::Name& qname,
-                     const isc::dns::RRClass& qclass,
-                     const isc::dns::RRType& qtype,
-                     isc::dns::RRsetList& target, uint32_t& flags,
-                     const isc::dns::Name* zonename) const
-    {
-        return (NOT_IMPLEMENTED);
-    }
-
-    Result findExactRRset(const Query& q, const isc::dns::Name& qname,
-                          const isc::dns::RRClass& qclass,
-                          const isc::dns::RRType& qtype,
-                          isc::dns::RRsetList& target, uint32_t& flags,
-                          const isc::dns::Name* zonename) const
-    {
-        return (NOT_IMPLEMENTED);
-    }
-
-    Result findAddrs(const Query& q, const isc::dns::Name& qname,
-                     const isc::dns::RRClass& qclass,
-                     isc::dns::RRsetList& target, uint32_t& flags,
-                     const isc::dns::Name* zonename) const
-    {
-        return (NOT_IMPLEMENTED);
-    }
-
-    Result findReferral(const Query& q, const isc::dns::Name& qname,
-                        const isc::dns::RRClass& qclass,
-                        isc::dns::RRsetList& target, uint32_t& flags,
-                        const isc::dns::Name* zonename) const
-    {
-        return (NOT_IMPLEMENTED);
-    }
-
-    virtual Result findPreviousName(const Query& q,
-                                    const isc::dns::Name& qname,
-                                    isc::dns::Name& target,
-                                    const isc::dns::Name* zonename) const
-    {
-        return (NOT_IMPLEMENTED);
-    }
-
-   virtual Result findCoveringNSEC3(const Query& q,
-                                    const isc::dns::Name& zonename,
-                                    std::string& hash,
-                                    isc::dns::RRsetList& target) const
+    Result findRRset(const Query& q UNUSED_PARAM,
+                     const isc::dns::Name& qname UNUSED_PARAM,
+                     const isc::dns::RRClass& qclass UNUSED_PARAM,
+                     const isc::dns::RRType& qtype UNUSED_PARAM,
+                     isc::dns::RRsetList& target UNUSED_PARAM,
+                     uint32_t& flags UNUSED_PARAM,
+                     const isc::dns::Name* zonename UNUSED_PARAM) const
+    {
+        return (NOT_IMPLEMENTED);
+    }
+
+    Result findExactRRset(const Query& q UNUSED_PARAM,
+                          const isc::dns::Name& qname UNUSED_PARAM,
+                          const isc::dns::RRClass& qclass UNUSED_PARAM,
+                          const isc::dns::RRType& qtype UNUSED_PARAM,
+                          isc::dns::RRsetList& target UNUSED_PARAM,
+                          uint32_t& flags UNUSED_PARAM,
+                          const isc::dns::Name* zonename UNUSED_PARAM) const
+    {
+        return (NOT_IMPLEMENTED);
+    }
+
+    Result findAddrs(const Query& q UNUSED_PARAM,
+                     const isc::dns::Name& qname UNUSED_PARAM,
+                     const isc::dns::RRClass& qclass UNUSED_PARAM,
+                     isc::dns::RRsetList& target UNUSED_PARAM,
+                     uint32_t& flags UNUSED_PARAM,
+                     const isc::dns::Name* zonename UNUSED_PARAM) const
+    {
+        return (NOT_IMPLEMENTED);
+    }
+
+    Result findReferral(const Query& q UNUSED_PARAM,
+                        const isc::dns::Name& qname UNUSED_PARAM,
+                        const isc::dns::RRClass& qclass UNUSED_PARAM,
+                        isc::dns::RRsetList& target UNUSED_PARAM,
+                        uint32_t& flags UNUSED_PARAM,
+                        const isc::dns::Name* zonename UNUSED_PARAM) const
+    {
+        return (NOT_IMPLEMENTED);
+    }
+
+    virtual Result findPreviousName(
+        const Query& q UNUSED_PARAM,
+        const isc::dns::Name& qname UNUSED_PARAM,
+        isc::dns::Name& target UNUSED_PARAM,
+        const isc::dns::Name* zonename UNUSED_PARAM) const
+    {
+        return (NOT_IMPLEMENTED);
+    }
+
+   virtual Result findCoveringNSEC3(
+       const Query& q UNUSED_PARAM,
+       const isc::dns::Name& zonename UNUSED_PARAM,
+       std::string& hash UNUSED_PARAM,
+       isc::dns::RRsetList& target UNUSED_PARAM) const
    {
        return (NOT_IMPLEMENTED);
    }

Modified: trunk/src/lib/auth/static_datasrc.h
==============================================================================
--- trunk/src/lib/auth/static_datasrc.h (original)
+++ trunk/src/lib/auth/static_datasrc.h Thu Mar 11 00:27:59 2010
@@ -88,7 +88,10 @@
                             isc::dns::RRsetList& target) const;
 
     Result init();
-    Result init(const isc::data::ElementPtr config) { return init(); };
+    // Static data source is "configuration less", so the \c config parameter
+    // is intentionally ignored.
+    Result init(const isc::data::ElementPtr config UNUSED_PARAM)
+    { return init(); };
     Result close();
 private:
     StaticDataSrcImpl* impl_;




More information about the bind10-changes mailing list