[svn] commit: r1353 - in /trunk/src/lib/dns: rdata.h rdata/generic/nsec3_50.cc rdata/generic/nsec_47.cc tests/dnssectime_unittest.cc tests/rdata_nsec3_unittest.cc tests/rdata_nsec_unittest.cc

[BIND 10 source code commits]

Author: each
Date: Fri Mar 12 06:11:41 2010
New Revision: 1353

Log:
- use DNSMessageFORMERR exception type instead of InvalidRdata
- use an explicit long-long constant for the dnssectime overflow test

Modified:
    trunk/src/lib/dns/rdata.h
    trunk/src/lib/dns/rdata/generic/nsec3_50.cc
    trunk/src/lib/dns/rdata/generic/nsec_47.cc
    trunk/src/lib/dns/tests/dnssectime_unittest.cc
    trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc
    trunk/src/lib/dns/tests/rdata_nsec_unittest.cc

Modified: trunk/src/lib/dns/rdata.h
==============================================================================
--- trunk/src/lib/dns/rdata.h (original)
+++ trunk/src/lib/dns/rdata.h Fri Mar 12 06:11:41 2010
@@ -53,17 +53,6 @@
     InvalidRdataText(const char* file, size_t line, const char* what) :
         isc::Exception(file, line, what) {}
 };
-
-///
-/// \brief A standard DNS module exception that is thrown if wire format
-/// RDTA is invalid
-///
-class InvalidRdata : public Exception {
-public:
-    InvalidRdata(const char* file, size_t line, const char* what) :
-        isc::Exception(file, line, what) {}
-};
-
 
 ///
 /// \brief A standard DNS module exception that is thrown if RDATA parser

Modified: trunk/src/lib/dns/rdata/generic/nsec3_50.cc
==============================================================================
--- trunk/src/lib/dns/rdata/generic/nsec3_50.cc (original)
+++ trunk/src/lib/dns/rdata/generic/nsec3_50.cc Fri Mar 12 06:11:41 2010
@@ -24,6 +24,7 @@
 
 #include "base32.h"
 #include "buffer.h"
+#include "exceptions.h"
 #include "hex.h"
 #include "messagerenderer.h"
 #include "name.h"
@@ -170,11 +171,13 @@
     int len = 0;
     for (int i = 0; i < typebits.size(); i += len) {
         if (i + 2 > typebits.size()) {
-            isc_throw(InvalidRdata, "Bad NSEC3 typebits");
+            isc_throw(DNSMessageFORMERR, "Invalid rdata: "
+                                         "bad NSEC3 type bitmap");
         }
         len = typebits[i + 1];
         if (len > 31) {
-            isc_throw(InvalidRdata, "Bad NSEC3 typebits");
+            isc_throw(DNSMessageFORMERR, "Invalid rdata: "
+                                         "bad NSEC3 type bitmap");
         }
         i += 2;
     }

Modified: trunk/src/lib/dns/rdata/generic/nsec_47.cc
==============================================================================
--- trunk/src/lib/dns/rdata/generic/nsec_47.cc (original)
+++ trunk/src/lib/dns/rdata/generic/nsec_47.cc Fri Mar 12 06:11:41 2010
@@ -23,6 +23,7 @@
 
 #include "base64.h"
 #include "buffer.h"
+#include "exceptions.h"
 #include "messagerenderer.h"
 #include "name.h"
 #include "rrtype.h"
@@ -110,11 +111,13 @@
     int len = 0;
     for (int i = 0; i < typebits.size(); i += len) {
         if (i + 2 > typebits.size()) {
-            isc_throw(InvalidRdata, "Bad NSEC typebits");
+            isc_throw(DNSMessageFORMERR, "Invalid rdata: "
+                                         "bad NSEC type bitmap");
         }
         len = typebits[i + 1];
         if (len > 31) {
-            isc_throw(InvalidRdata, "Bad NSEC typebits");
+            isc_throw(DNSMessageFORMERR, "Invalid rdata: "
+                                         "bad NSEC type bitmap");
         }
         i += 2;
     }

Modified: trunk/src/lib/dns/tests/dnssectime_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/dnssectime_unittest.cc (original)
+++ trunk/src/lib/dns/tests/dnssectime_unittest.cc Fri Mar 12 06:11:41 2010
@@ -63,6 +63,6 @@
     EXPECT_EQ("20100311233000", timeToText(1268350200));
 
     // Jan 1, Year 10,000.  What should we do?
-    EXPECT_THROW(timeToText(253402300800), InvalidTime);
+    EXPECT_THROW(timeToText(253402300800LL), InvalidTime);
 }
 }

Modified: trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc Fri Mar 12 06:11:41 2010
@@ -18,6 +18,7 @@
 
 #include <dns/base32.h>
 #include <dns/buffer.h>
+#include <dns/exceptions.h>
 #include <dns/hex.h>
 #include <dns/messagerenderer.h>
 #include <dns/rdata.h>
@@ -88,7 +89,7 @@
     // Invalid type bits
     EXPECT_THROW(rdataFactoryFromFile(RRType::NSEC3(), RRClass::IN(),
                                       "testdata/rdata_nsec3_fromWire3"),
-                 InvalidRdata);
+                 DNSMessageFORMERR);
 }
 
 TEST_F(Rdata_NSEC3_Test, toWireRenderer)

Modified: trunk/src/lib/dns/tests/rdata_nsec_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_nsec_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_nsec_unittest.cc Fri Mar 12 06:11:41 2010
@@ -17,6 +17,7 @@
 #include <string>
 
 #include <dns/buffer.h>
+#include <dns/exceptions.h>
 #include <dns/messagerenderer.h>
 #include <dns/rdata.h>
 #include <dns/rdataclass.h>
@@ -68,7 +69,7 @@
 
     EXPECT_THROW(rdataFactoryFromFile(RRType::NSEC(), RRClass::IN(),
                        "testdata/rdata_nsec_fromWire3"),
-                 InvalidRdata);
+                 DNSMessageFORMERR);
 }
 
 TEST_F(Rdata_NSEC_Test, toWireRenderer_NSEC)