[svn] commit: r1455 - in /trunk/src/lib/dns/tests: rdata_dnskey_unittest.cc rdata_ds_unittest.cc rdata_nsec3_unittest.cc rdata_nsec3param_unittest.cc rdata_rrsig_unittest.cc

[BIND 10 source code commits]

Author: jinmei
Date: Tue Mar 16 18:22:02 2010
New Revision: 1455

Log:
added tests that would fail (commented out)

Modified:
    trunk/src/lib/dns/tests/rdata_dnskey_unittest.cc
    trunk/src/lib/dns/tests/rdata_ds_unittest.cc
    trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc
    trunk/src/lib/dns/tests/rdata_nsec3param_unittest.cc
    trunk/src/lib/dns/tests/rdata_rrsig_unittest.cc

Modified: trunk/src/lib/dns/tests/rdata_dnskey_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_dnskey_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_dnskey_unittest.cc Tue Mar 16 18:22:02 2010
@@ -73,13 +73,15 @@
                  InvalidRdataText);
     EXPECT_THROW(generic::DNSKEY("257 3 5 BAAAAAAAAAAAD"),
                  BadBase64String);
-    // Should this be allowed?
-//     EXPECT_THROW(generic::DNSKEY("257 3 5BEAAEFTd"),
-//                  InvalidRdataText);
+#if 0
+    // Should this be allowed?  Probably not.  But the test currently fails.
+    EXPECT_THROW(generic::DNSKEY("257 3 5BEAAEFTd"),
+                 InvalidRdataText);
     // How about this?  It's even more confusing for the parser because
     // it could be ambiguous '51 EAAA' vs '5 1EAA..'
-//     EXPECT_THROW(generic::DNSKEY("257 3 51EAAEFTd"),
-//                  InvalidRdataText);
+    EXPECT_THROW(generic::DNSKEY("257 3 51EAAEFTd"),
+                 InvalidRdataText);
+#endif
 }
 
 TEST_F(Rdata_DNSKEY_Test, toWireRenderer)

Modified: trunk/src/lib/dns/tests/rdata_ds_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_ds_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_ds_unittest.cc Tue Mar 16 18:22:02 2010
@@ -52,6 +52,13 @@
     EXPECT_THROW(const generic::DS ds2("11111 5 22222 BEEF"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("11111 5 2"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("GARBAGE IN"), InvalidRdataText);
+
+#if 0              // this test currently fails
+    // no space between the digest type and the digest.
+    EXPECT_THROW(const generic::DS ds2(
+                     "12892 5 2F1E184C0E1D615D20EB3C223ACED3B03C773DD952D"
+                     "5F0EB5C777586DE18DA6B5"), InvalidRdataText);
+#endif
 }
 
 TEST_F(Rdata_DS_Test, createFromWire_DS) {

Modified: trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_nsec3_unittest.cc Tue Mar 16 18:22:02 2010
@@ -72,6 +72,12 @@
                                             "0123456789ABCDEFGHIJKLMNOPQRSTUV "
                                             "A NS SOA"),
                  InvalidRdataText);
+
+#if 0 // this currently fails
+    EXPECT_THROW(generic::NSEC3(
+                     "1 1 1D399EAAB H9RSFB7FPF2L8HG35CMPC765TDK23RP6 "
+                     "NS SOA RRSIG DNSKEY NSEC3PARAM"), InvalidRdataText);
+#endif
 }
 
 TEST_F(Rdata_NSEC3_Test, createFromWire)

Modified: trunk/src/lib/dns/tests/rdata_nsec3param_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_nsec3param_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_nsec3param_unittest.cc Tue Mar 16 18:22:02 2010
@@ -49,16 +49,15 @@
 
 TEST_F(Rdata_NSEC3PARAM_Test, badText)
 {
-    EXPECT_THROW(generic::NSEC3PARAM rdata_nsec3param("1 1 1 SPORK"),
-                 BadHexString);
-    EXPECT_THROW(generic::NSEC3PARAM rdata_nsec3param("100000 1 1 ADDAFEE"),
-                 InvalidRdataText);
-    EXPECT_THROW(generic::NSEC3PARAM rdata_nsec3param("1 100000 1 ADDAFEE"),
-                 InvalidRdataText);
-    EXPECT_THROW(generic::NSEC3PARAM rdata_nsec3param("1 1 100000 ADDAFEE"),
-                 InvalidRdataText);
-    EXPECT_THROW(generic::NSEC3PARAM rdata_nsec3param("1"),
-                 InvalidRdataText);
+    EXPECT_THROW(generic::NSEC3PARAM("1 1 1 SPORK"), BadHexString);
+    EXPECT_THROW(generic::NSEC3PARAM("100000 1 1 ADDAFEE"), InvalidRdataText);
+    EXPECT_THROW(generic::NSEC3PARAM("1 100000 1 ADDAFEE"), InvalidRdataText);
+    EXPECT_THROW(generic::NSEC3PARAM("1 1 100000 ADDAFEE"), InvalidRdataText);
+    EXPECT_THROW(generic::NSEC3PARAM("1"), InvalidRdataText);
+
+#if 0                           // this currently fails
+    EXPECT_THROW(generic::NSEC3PARAM("1 0 1D399EAAB"), InvalidRdataText);
+#endif
 }
 
 TEST_F(Rdata_NSEC3PARAM_Test, createFromWire)

Modified: trunk/src/lib/dns/tests/rdata_rrsig_unittest.cc
==============================================================================
--- trunk/src/lib/dns/tests/rdata_rrsig_unittest.cc (original)
+++ trunk/src/lib/dns/tests/rdata_rrsig_unittest.cc Tue Mar 16 18:22:02 2010
@@ -87,6 +87,12 @@
                      "20100223214617 20100222214617 8496 isc.org. "
                      "EEeeeeeeEEEeeeeeeGaaahAAAAAAAAHHHHHHHHHHH!="),
                      BadBase64String);
+
+#if 0                           // this currently fails
+    // no space between the tag and signer
+    EXPECT_THROW(generic::RRSIG("A 5 4 43200 20100223214617 20100222214617 "
+                                "8496isc.org. ofc="), InvalidRdataText);
+#endif
 }
 
 TEST_F(Rdata_RRSIG_Test, toWireRenderer)