[svn] commit: r1805 - /branches/trac177/src/lib/dns/tests/name_unittest.cc

[BIND 10 source code commits]

Author: jinmei
Date: Mon May 10 19:56:47 2010
New Revision: 1805

Log:
on second thought, it would be much better to make the test size-indendent
using numeric_limits<unsigned int>::max().

Modified:
    branches/trac177/src/lib/dns/tests/name_unittest.cc

Modified: branches/trac177/src/lib/dns/tests/name_unittest.cc
==============================================================================
--- branches/trac177/src/lib/dns/tests/name_unittest.cc (original)
+++ branches/trac177/src/lib/dns/tests/name_unittest.cc Mon May 10 19:56:47 2010
@@ -18,6 +18,7 @@
 #include <string>
 #include <sstream>
 #include <iomanip>
+#include <limits>
 #include <stdexcept>
 
 #include <dns/buffer.h>
@@ -493,11 +494,10 @@
     EXPECT_THROW(example_name.split(1, 0), OutOfRange);
     EXPECT_THROW(example_name.split(2, 3), OutOfRange);
 
-    // invalid range: (assuming int is 32-bit) the following parameters would
-    // cause overflow, bypassing naive validation.
-    if (sizeof(int) == 4) {
-        EXPECT_THROW(example_name.split(1, 0xffffffff), OutOfRange);
-    }
+    // invalid range: the following parameters would cause overflow,
+    // bypassing naive validation.
+    EXPECT_THROW(example_name.split(1, numeric_limits<unsigned int>::max()),
+                 OutOfRange);
 }
 
 TEST_F(NameTest, downcase) {