[svn] commit: r1969 - /branches/trac168/src/lib/datasrc/tests/sqlite3_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Sat May 29 00:29:14 UTC 2010


Author: jinmei
Date: Sat May 29 00:29:14 2010
New Revision: 1969

Log:
on further check, ASSERT_EQ doesn't seem to solve the reported "problem".
revert to EXPECT_EQ.

Modified:
    branches/trac168/src/lib/datasrc/tests/sqlite3_unittest.cc

Modified: branches/trac168/src/lib/datasrc/tests/sqlite3_unittest.cc
==============================================================================
--- branches/trac168/src/lib/datasrc/tests/sqlite3_unittest.cc (original)
+++ branches/trac168/src/lib/datasrc/tests/sqlite3_unittest.cc Sat May 29 00:29:14 2010
@@ -376,8 +376,8 @@
 
     NameMatch name_match(www_name);
     data_source.findClosestEnclosure(name_match, rrclass);
-    ASSERT_EQ(NULL, name_match.closestName());
-    ASSERT_EQ(NULL, name_match.bestDataSrc());
+    EXPECT_EQ(NULL, name_match.closestName());
+    EXPECT_EQ(NULL, name_match.bestDataSrc());
 }
 
 TEST_F(Sqlite3DataSourceTest, openFail) {
@@ -441,15 +441,15 @@
 TEST_F(Sqlite3DataSourceTest, findClosestEnclosureNoMatch) {
     NameMatch name_match(nomatch_name);
     data_source.findClosestEnclosure(name_match, rrclass);
-    ASSERT_EQ(NULL, name_match.closestName());
-    ASSERT_EQ(NULL, name_match.bestDataSrc());
+    EXPECT_EQ(NULL, name_match.closestName());
+    EXPECT_EQ(NULL, name_match.bestDataSrc());
 }
 
 TEST_F(Sqlite3DataSourceTest, findClosestClassMismatch) {
     NameMatch name_match(www_name);
     data_source.findClosestEnclosure(name_match, rrclass_notmatch);
-    ASSERT_EQ(NULL, name_match.closestName());
-    ASSERT_EQ(NULL, name_match.bestDataSrc());
+    EXPECT_EQ(NULL, name_match.closestName());
+    EXPECT_EQ(NULL, name_match.bestDataSrc());
 }
 
 // If the query class is ANY, the result should be the same as the case where




More information about the bind10-changes mailing list