[svn] commit: r3490 - in /branches/trac409/src/lib: cc/data.cc config/tests/fake_session.cc config/tests/fake_session.h datasrc/data_source.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Nov 8 16:01:32 UTC 2010


Author: jinmei
Date: Mon Nov  8 16:01:31 2010
New Revision: 3490

Log:
more cleanup:
- removed obsolete comment about UNUSED_PARAM
- omitting more unused parameters (that didn't cause a warning simply because we specified -Wno-unused-parameter

Modified:
    branches/trac409/src/lib/cc/data.cc
    branches/trac409/src/lib/config/tests/fake_session.cc
    branches/trac409/src/lib/config/tests/fake_session.h
    branches/trac409/src/lib/datasrc/data_source.cc

Modified: branches/trac409/src/lib/cc/data.cc
==============================================================================
--- branches/trac409/src/lib/cc/data.cc (original)
+++ branches/trac409/src/lib/cc/data.cc Mon Nov  8 16:01:31 2010
@@ -719,7 +719,7 @@
 }
 
 ElementPtr
-Element::fromWire(std::stringstream& in, int length) {
+Element::fromWire(std::stringstream& in, int) {
     //
     // Check protocol version
     //

Modified: branches/trac409/src/lib/config/tests/fake_session.cc
==============================================================================
--- branches/trac409/src/lib/config/tests/fake_session.cc (original)
+++ branches/trac409/src/lib/config/tests/fake_session.cc Mon Nov  8 16:01:31 2010
@@ -91,7 +91,7 @@
 }
 
 void
-FakeSession::establish(const char* socket_file) {
+FakeSession::establish(const char*) {
 }
 
 bool

Modified: branches/trac409/src/lib/config/tests/fake_session.h
==============================================================================
--- branches/trac409/src/lib/config/tests/fake_session.h (original)
+++ branches/trac409/src/lib/config/tests/fake_session.h Mon Nov  8 16:01:31 2010
@@ -63,7 +63,7 @@
     virtual int reply(isc::data::ConstElementPtr envelope,
                       isc::data::ConstElementPtr newmsg);
     virtual bool hasQueuedMsgs() const;
-    virtual void setTimeout(size_t milliseconds) {}
+    virtual void setTimeout(size_t) {}
     virtual size_t getTimeout() const { return (0); }
     isc::data::ConstElementPtr getFirstMessage(std::string& group,
                                                std::string& to) const;

Modified: branches/trac409/src/lib/datasrc/data_source.cc
==============================================================================
--- branches/trac409/src/lib/datasrc/data_source.cc (original)
+++ branches/trac409/src/lib/datasrc/data_source.cc Mon Nov  8 16:01:31 2010
@@ -1247,13 +1247,6 @@
     return (encodeBase32Hex(vector<uint8_t>(digest, digest + SHA1_HASHSIZE)));
 }
 
-//
-// The following methods are effectively empty, and their parameters are
-// unused.  To silence compilers that warn unused function parameters,
-// we specify a (compiler dependent) special keyword when available.
-// It's defined in config.h, and to avoid including this header file from
-// installed files we define the methods here.
-//
 DataSrc::Result
 DataSrc::init(isc::data::ConstElementPtr) {
     return (NOT_IMPLEMENTED);




More information about the bind10-changes mailing list