[svn] commit: r3578 - in /branches/trac408/src/lib/nsas: nameserver_address_store.cc nameserver_entry.h zone_entry.h
BIND 10 source code commits
bind10-changes at lists.isc.org
Sat Nov 20 17:54:13 UTC 2010
Author: vorner
Date: Sat Nov 20 17:54:13 2010
New Revision: 3578
Log:
Few TODO notes
Modified:
branches/trac408/src/lib/nsas/nameserver_address_store.cc
branches/trac408/src/lib/nsas/nameserver_entry.h
branches/trac408/src/lib/nsas/zone_entry.h
Modified: branches/trac408/src/lib/nsas/nameserver_address_store.cc
==============================================================================
--- branches/trac408/src/lib/nsas/nameserver_address_store.cc (original)
+++ branches/trac408/src/lib/nsas/nameserver_address_store.cc Sat Nov 20 17:54:13 2010
@@ -139,6 +139,8 @@
zone_lru_.touch(zone_ptr);
}
zone_ptr->addCallback(callback);
+ // TODO Do this only when there are no callbacks currently
+ // if there are, it means this will be just added as well
processZone(zone_ptr);
}
@@ -169,6 +171,9 @@
}
+// TODO Pass a nameserver that is responsible for this, as it is not
+// checked for TTL (might be 0)
+// TODO Move this to the zone
void NameserverAddressStore::processZone(ZonePtr zone) {
// Addresses of existing nameservers
NameserverEntry::AddressVector addresses;
Modified: branches/trac408/src/lib/nsas/nameserver_entry.h
==============================================================================
--- branches/trac408/src/lib/nsas/nameserver_entry.h (original)
+++ branches/trac408/src/lib/nsas/nameserver_entry.h Sat Nov 20 17:54:13 2010
@@ -245,6 +245,7 @@
//@}
private:
+ // TODO Read-write lock?
boost::mutex mutex_; ///< Mutex protecting this object
std::string name_; ///< Canonical name of the nameserver
uint16_t classCode_; ///< Class of the nameserver
Modified: branches/trac408/src/lib/nsas/zone_entry.h
==============================================================================
--- branches/trac408/src/lib/nsas/zone_entry.h (original)
+++ branches/trac408/src/lib/nsas/zone_entry.h Sat Nov 20 17:54:13 2010
@@ -83,6 +83,8 @@
return HashKey(name_, classCode_);
}
+ // TODO The callbacks must be distinguished - A, AAAA or any of them
+
/// \short Add another callback here
void addCallback(boost::shared_ptr<AddressRequestCallback> callback);
/// \short Is there at last one callback waiting?
@@ -129,6 +131,7 @@
const_iterator end() const { return (nameservers_.end()); }
//@}
+ // TODO Get rid of this
/**
* \short Lock of the zone entry.
*
@@ -163,6 +166,7 @@
*/
Lock getLock();
private:
+ // TODO Read-Write lock?
mutable boost::mutex mutex_; ///< Mutex protecting this zone entry
std::string name_; ///< Canonical zone name
uint16_t classCode_; ///< Class code
More information about the bind10-changes
mailing list