[svn] commit: r3224 - in /trunk/src/lib/dns: gen-rdatacode.py.in name.h rdata/generic/mx_15.h rdata/generic/soa_6.h rrset.h

[BIND 10 source code commits]

Author: jinmei
Date: Fri Oct 15 08:28:59 2010
New Revision: 3224

Log:
cleanup: removed meaningless 'explicit' for multi-param constructors.
should be quite trivial, so I'm skipping explicit review.
if someone could perform sanity check on the diff copied with this message that would be great.

Modified:
    trunk/src/lib/dns/gen-rdatacode.py.in
    trunk/src/lib/dns/name.h
    trunk/src/lib/dns/rdata/generic/mx_15.h
    trunk/src/lib/dns/rdata/generic/soa_6.h
    trunk/src/lib/dns/rrset.h

Modified: trunk/src/lib/dns/gen-rdatacode.py.in
==============================================================================
--- trunk/src/lib/dns/gen-rdatacode.py.in (original)
+++ trunk/src/lib/dns/gen-rdatacode.py.in Fri Oct 15 08:28:59 2010
@@ -113,7 +113,7 @@
         if re.match('\s+// BEGIN_COMMON_MEMBERS$', line):
             content += '''
     explicit ''' + type_utxt + '''(const std::string& type_str);
-    explicit ''' + type_utxt + '''(InputBuffer& buffer, size_t rdata_len);
+    ''' + type_utxt + '''(InputBuffer& buffer, size_t rdata_len);
     ''' + type_utxt + '''(const ''' + type_utxt + '''& other);
     virtual std::string toText() const;
     virtual void toWire(OutputBuffer& buffer) const;

Modified: trunk/src/lib/dns/name.h
==============================================================================
--- trunk/src/lib/dns/name.h (original)
+++ trunk/src/lib/dns/name.h Fri Oct 15 08:28:59 2010
@@ -143,8 +143,8 @@
     ///
     /// This constructor simply initializes the object in the straightforward
     /// way.
-    explicit NameComparisonResult(int order, unsigned int nlabels,
-                                  NameRelation relation) :
+    NameComparisonResult(int order, unsigned int nlabels,
+                         NameRelation relation) :
         order_(order), nlabels_(nlabels), relation_(relation) {}
     //@}
 

Modified: trunk/src/lib/dns/rdata/generic/mx_15.h
==============================================================================
--- trunk/src/lib/dns/rdata/generic/mx_15.h (original)
+++ trunk/src/lib/dns/rdata/generic/mx_15.h Fri Oct 15 08:28:59 2010
@@ -35,7 +35,7 @@
     // BEGIN_COMMON_MEMBERS
     // END_COMMON_MEMBERS
 
-    explicit MX(uint16_t preference, const Name& mxname);
+    MX(uint16_t preference, const Name& mxname);
 
     ///
     /// Specialized methods

Modified: trunk/src/lib/dns/rdata/generic/soa_6.h
==============================================================================
--- trunk/src/lib/dns/rdata/generic/soa_6.h (original)
+++ trunk/src/lib/dns/rdata/generic/soa_6.h Fri Oct 15 08:28:59 2010
@@ -33,9 +33,9 @@
     // BEGIN_COMMON_MEMBERS
     // END_COMMON_MEMBERS
 
-    explicit SOA(const Name& mname, const Name& rname, uint32_t serial,
-                 uint32_t refresh, uint32_t retry, uint32_t expire,
-                 uint32_t minimum);
+    SOA(const Name& mname, const Name& rname, uint32_t serial,
+        uint32_t refresh, uint32_t retry, uint32_t expire,
+        uint32_t minimum);
 private:
     /// Note: this is a prototype version; we may reconsider
     /// this representation later.

Modified: trunk/src/lib/dns/rrset.h
==============================================================================
--- trunk/src/lib/dns/rrset.h (original)
+++ trunk/src/lib/dns/rrset.h Fri Oct 15 08:28:59 2010
@@ -530,8 +530,8 @@
     /// \param rrclass The RR class of the RRset.
     /// \param rrtype The RR type of the RRset.
     /// \param ttl The TTL of the RRset.
-    explicit BasicRRset(const Name& name, const RRClass& rrclass,
-                        const RRType& rrtype, const RRTTL& ttl);
+    BasicRRset(const Name& name, const RRClass& rrclass,
+               const RRType& rrtype, const RRTTL& ttl);
     /// \brief The destructor.
     virtual ~BasicRRset();
     //@}
@@ -668,7 +668,7 @@
 /// QNAME/QTYPE/QCLASS as a single object.
 class RRset : public BasicRRset {
 public:
-    explicit RRset(const Name& name, const RRClass& rrclass,
+    RRset(const Name& name, const RRClass& rrclass,
           const RRType& rrtype, const RRTTL& ttl);
 
     virtual ~RRset();