BIND 10 trac404, updated. 87c6ef9942c9edcb37aa811e1c20357e6bd6bc4b [trac404] Spelling fixes

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Apr 12 18:19:28 UTC 2011


The branch, trac404 has been updated
       via  87c6ef9942c9edcb37aa811e1c20357e6bd6bc4b (commit)
       via  95e81e5a713c145307034724994bd64bf35455ff (commit)
      from  34571fc51116f3e476e84c20e7fb7ba59393dab8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 87c6ef9942c9edcb37aa811e1c20357e6bd6bc4b
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Tue Apr 12 19:57:43 2011 +0200

    [trac404] Spelling fixes

commit 95e81e5a713c145307034724994bd64bf35455ff
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Tue Apr 12 19:53:21 2011 +0200

    [trac404] Note about design

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/messagerenderer.h |   12 +++++++++++-
 src/lib/dns/rdatafields.cc    |    2 +-
 2 files changed, 12 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/messagerenderer.h b/src/lib/dns/messagerenderer.h
index 90831ea..ea2ef84 100644
--- a/src/lib/dns/messagerenderer.h
+++ b/src/lib/dns/messagerenderer.h
@@ -53,6 +53,16 @@ class Name;
 /// renderer class for specific purposes.  For example, a high performance
 /// DNS server may want to use an optimized renderer class assuming some
 /// specific underlying data representation.
+///
+/// \note Some functions (like writeUint8) are not virtual. It is because
+///     it is hard to imagine any version of message renderer that would
+///     do anything else than just putting the data into a buffer, so we
+///     provide a default implementation and having them virtual would only
+///     hurt the performance with no real gain. If it would happen a different
+///     implementation is really needed, we can make them virtual in future.
+///     The only one that is virtual is writeName and it's because this
+///     function is much more complicated, therefore there's a lot of space
+///     for different implementations or behaviours.
 class AbstractMessageRenderer {
 public:
     /// \brief Compression mode constants.
@@ -96,7 +106,7 @@ protected:
     /// \short Buffer to store data
     ///
     /// It was decided that there's no need to have this in every subclass,
-    /// at last not now, and this reduces code size and gives compiler a better
+    /// at least not now, and this reduces code size and gives compiler a better
     /// chance to optimise.
     OutputBuffer& buffer_;
 public:
diff --git a/src/lib/dns/rdatafields.cc b/src/lib/dns/rdatafields.cc
index 49634c6..196f3c7 100644
--- a/src/lib/dns/rdatafields.cc
+++ b/src/lib/dns/rdatafields.cc
@@ -116,7 +116,7 @@ public:
         return (fields_);
     }
     // We use generict write* methods, with the exception of writeName.
-    // So new data can arriwe without us knowing it, this considers all new
+    // So new data can arrive without us knowing it, this considers all new
     // data to be just data and extends the fields to take it into account.
     size_t last_data_pos_;
     void extendData() {




More information about the bind10-changes mailing list