BIND 10 master, updated. 0b98878ed8a185cbc3b78c860019416bfed317bb [master] catch by reference (caught by cppcheck)

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Aug 4 11:32:48 UTC 2011


The branch, master has been updated
       via  0b98878ed8a185cbc3b78c860019416bfed317bb (commit)
      from  747d2952c78ee32acc485946d3922cfe899a4b48 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0b98878ed8a185cbc3b78c860019416bfed317bb
Author: Jelte Jansen <jelte at isc.org>
Date:   Thu Aug 4 13:29:59 2011 +0200

    [master] catch by reference (caught by cppcheck)

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/rdata/any_255/tsig_250.cc |    2 +-
 src/lib/dns/rdata/in_1/srv_33.cc      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/rdata/any_255/tsig_250.cc b/src/lib/dns/rdata/any_255/tsig_250.cc
index aeb1b3b..04a4dc4 100644
--- a/src/lib/dns/rdata/any_255/tsig_250.cc
+++ b/src/lib/dns/rdata/any_255/tsig_250.cc
@@ -153,7 +153,7 @@ TSIG::TSIG(const std::string& tsig_str) : impl_(NULL) {
         impl_ = new TSIGImpl(algorithm, time_signed, fudge, mac, orig_id,
                             error, other_data);
 
-    } catch (StringTokenError ste) {
+    } catch (const StringTokenError& ste) {
         isc_throw(InvalidRdataText, "Invalid TSIG text: " << ste.what() <<
                   ": " << tsig_str);
     }
diff --git a/src/lib/dns/rdata/in_1/srv_33.cc b/src/lib/dns/rdata/in_1/srv_33.cc
index 50ae665..93b5d4d 100644
--- a/src/lib/dns/rdata/in_1/srv_33.cc
+++ b/src/lib/dns/rdata/in_1/srv_33.cc
@@ -84,7 +84,7 @@ SRV::SRV(const string& srv_str) :
         }
 
         impl_ = new SRVImpl(priority, weight, port, targetname);
-    } catch (StringTokenError ste) {
+    } catch (const StringTokenError& ste) {
         isc_throw(InvalidRdataText, "Invalid SRV text: " <<
                   ste.what() << ": " << srv_str);
     }




More information about the bind10-changes mailing list