BIND 10 master, updated. ee2a86bd4c1472e606b3d59ef5c4392b61d7ab48 [master] fix bug in bindctl 'config add'

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Aug 5 08:27:44 UTC 2011


The branch, master has been updated
       via  ee2a86bd4c1472e606b3d59ef5c4392b61d7ab48 (commit)
      from  0b98878ed8a185cbc3b78c860019416bfed317bb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ee2a86bd4c1472e606b3d59ef5c4392b61d7ab48
Author: Jelte Jansen <jelte at isc.org>
Date:   Fri Aug 5 10:27:16 2011 +0200

    [master] fix bug in bindctl 'config add'
    
    reviewed on jabber

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/config/ccsession.py            |    4 ++--
 src/lib/python/isc/config/tests/ccsession_test.py |    2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/config/ccsession.py b/src/lib/python/isc/config/ccsession.py
index 8150729..4fa9d58 100644
--- a/src/lib/python/isc/config/ccsession.py
+++ b/src/lib/python/isc/config/ccsession.py
@@ -425,7 +425,7 @@ class UIModuleCCSession(MultiConfigData):
             raise ModuleCCSessionError("Bad config version")
         self._set_current_config(config)
 
-    def _add_value_to_list(self, identifier, value):
+    def _add_value_to_list(self, identifier, value, module_spec):
         cur_list, status = self.get_value(identifier)
         if not cur_list:
             cur_list = []
@@ -491,7 +491,7 @@ class UIModuleCCSession(MultiConfigData):
                 if set_value_str is not None:
                     value_str += set_value_str
                 value = isc.cc.data.parse_value_str(value_str)
-            self._add_value_to_list(identifier, value)
+            self._add_value_to_list(identifier, value, module_spec)
         elif 'named_set_item_spec' in module_spec:
             item_name = None
             item_value = None
diff --git a/src/lib/python/isc/config/tests/ccsession_test.py b/src/lib/python/isc/config/tests/ccsession_test.py
index c820ad9..351c8e6 100644
--- a/src/lib/python/isc/config/tests/ccsession_test.py
+++ b/src/lib/python/isc/config/tests/ccsession_test.py
@@ -745,6 +745,8 @@ class TestUIModuleCCSession(unittest.TestCase):
                           uccs.remove_value, "Spec2/item5[123]", None)
         uccs.remove_value("Spec2/item5[0]", None)
         self.assertEqual({'Spec2': {'item5': []}}, uccs._local_changes)
+        uccs.add_value("Spec2/item5", None);
+        self.assertEqual({'Spec2': {'item5': ['']}}, uccs._local_changes)
 
     def test_add_remove_value_named_set(self):
         fake_conn = fakeUIConn()




More information about the bind10-changes mailing list