BIND 10 trac1113, updated. 83f8d6de769a33f51b83cd81efe178db162e95e1 [trac1113] minor comments fix
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Aug 17 05:10:19 UTC 2011
The branch, trac1113 has been updated
via 83f8d6de769a33f51b83cd81efe178db162e95e1 (commit)
from d7834356a301b162fb9757427359d0dbac95cecf (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 83f8d6de769a33f51b83cd81efe178db162e95e1
Author: chenzhengzhang <jerry.zzpku at gmail.com>
Date: Wed Aug 17 13:09:39 2011 +0800
[trac1113] minor comments fix
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/rdata/generic/minfo_14.h | 11 ++++++-----
src/lib/dns/tests/rdata_minfo_unittest.cc | 1 -
.../testdata/rdata_minfo_toWireUncompressed2.spec | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/rdata/generic/minfo_14.h b/src/lib/dns/rdata/generic/minfo_14.h
index f7afcc5..f3ee1d0 100644
--- a/src/lib/dns/rdata/generic/minfo_14.h
+++ b/src/lib/dns/rdata/generic/minfo_14.h
@@ -39,7 +39,8 @@ public:
/// \brief Define the assignment operator.
///
- /// This method never throws an exception.
+ /// \exception std::bad_alloc Memory allocation fails in copying
+ /// internal member variables (this should be very rare).
MINFO& operator=(const MINFO& source);
/// \brief Return the value of the rmailbox field.
@@ -52,11 +53,11 @@ public:
/// \c NS::getNSName()), this method constructs a new \c Name object
/// and returns it, instead of returning a reference to a \c Name object
/// internally maintained in the class (which is a private member).
- /// This is based on the observation that this method will be rarely used
- /// and even when it's used it will not be in a performance context
+ /// This is based on the observation that this method will be rarely
+ /// used and even when it's used it will not be in a performance context
/// (for example, a recursive resolver won't need this field in its
- /// resolution process). By returning a new object we have flexibility of
- /// changing the internal representation without the risk of changing
+ /// resolution process). By returning a new object we have flexibility
+ /// of changing the internal representation without the risk of changing
/// the interface or method property.
/// The same note applies to the \c getEmailbox() method.
Name getRmailbox() const { return (rmailbox_); }
diff --git a/src/lib/dns/tests/rdata_minfo_unittest.cc b/src/lib/dns/tests/rdata_minfo_unittest.cc
index 0956161..30c7c39 100644
--- a/src/lib/dns/tests/rdata_minfo_unittest.cc
+++ b/src/lib/dns/tests/rdata_minfo_unittest.cc
@@ -39,7 +39,6 @@ const char* const too_long_label = "01234567890123456789012345678901234567"
namespace {
class Rdata_MINFO_Test : public RdataTest {
- // there's nothing to specialize
public:
Rdata_MINFO_Test():
rdata_minfo(string(minfo_txt)), rdata_minfo2(string(minfo_txt2)) {}
diff --git a/src/lib/dns/tests/testdata/rdata_minfo_toWireUncompressed2.spec b/src/lib/dns/tests/testdata/rdata_minfo_toWireUncompressed2.spec
index 1182c2b..0f78fcc 100644
--- a/src/lib/dns/tests/testdata/rdata_minfo_toWireUncompressed2.spec
+++ b/src/lib/dns/tests/testdata/rdata_minfo_toWireUncompressed2.spec
@@ -1,5 +1,5 @@
#
-# A simplest form of MINFO: all default parameters
+# A simplest form of MINFO: custom rmailbox and default emailbox
#
[custom]
sections: minfo
More information about the bind10-changes
mailing list