BIND 10 trac1429, updated. 0e3736c7c3e882ba3f0616b9d0877792edd73317 [1429] Comments about blocking

[BIND 10 source code commits]

The branch, trac1429 has been updated
       via  0e3736c7c3e882ba3f0616b9d0877792edd73317 (commit)
      from  4220ef5ac9c8fdd4b506b3579f0e5eec98e3f3d8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0e3736c7c3e882ba3f0616b9d0877792edd73317
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Thu Dec 8 10:11:40 2011 +0100

    [1429] Comments about blocking

-----------------------------------------------------------------------

Summary of changes:
 src/bin/bind10/bind10_src.py.in |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/bind10/bind10_src.py.in b/src/bin/bind10/bind10_src.py.in
index 209899c..48e36ca 100755
--- a/src/bin/bind10/bind10_src.py.in
+++ b/src/bin/bind10/bind10_src.py.in
@@ -856,6 +856,9 @@ class BoB:
                                                        "Missing parameter " +
                                                        str(ke))
 
+            # FIXME: This call contains blocking IPC. It is expected to be
+            # short, but if it turns out to be problem, we'll need to do
+            # something about it.
             token = self._socket_cache.get_token(protocol, addr, port,
                                                  share_mode, share_name)
             return isc.config.ccsession.create_answer(0, {
@@ -873,6 +876,11 @@ class BoB:
         """
         try:
             fd = self._socket_cache.get_socket(token, unix_socket.fileno())
+            # FIXME: These two calls are blocking in their nature. An OS-level
+            # buffer is likely to be large enough to hold all these data, but
+            # if it wasn't and the remote application got stuck, we would have
+            # a problem. If there appear such problems, we should do something
+            # about it.
             unix_socket.sendall(CREATOR_SOCKET_OK)
             libutil_io_python.send_fd(unix_socket.fileno(), fd)
         except Exception as e: