BIND 10 trac1424, updated. 365c733b967c7b0a53122f62931d459d1ec63b35 [1424] added some more comments

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Dec 23 08:29:05 UTC 2011


The branch, trac1424 has been updated
       via  365c733b967c7b0a53122f62931d459d1ec63b35 (commit)
      from  2818dab13b61cdbbee27076e820e4069e3dd14d4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 365c733b967c7b0a53122f62931d459d1ec63b35
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Dec 23 00:28:58 2011 -0800

    [1424] added some more comments

-----------------------------------------------------------------------

Summary of changes:
 src/bin/resolver/tests/resolver_config_unittest.cc |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/resolver/tests/resolver_config_unittest.cc b/src/bin/resolver/tests/resolver_config_unittest.cc
index 35c70f5..7169331 100644
--- a/src/bin/resolver/tests/resolver_config_unittest.cc
+++ b/src/bin/resolver/tests/resolver_config_unittest.cc
@@ -258,16 +258,21 @@ TEST_F(ResolverConfig, listenOnAndOtherConfig) {
     // Create and bind a socket that would make the subsequent listen_on fail
     ScopedSocket sock(createSocket(TEST_ADDRESS, TEST_PORT));
 
+    // We are going to install a pair of "root_addresses" and "listen_on"
+    // in a single update.
     const string config_str("{\"root_addresses\": ["
                             " {\"address\": \"192.0.2.1\","
                             "   \"port\": 53}], "
                             "\"listen_on\": ["
                             " {\"address\": \"" + string(TEST_ADDRESS) + "\","
                             "  \"port\": " + string(TEST_PORT) + "}]}");
+    // Normally, if listen_on fails the rest of the config parameters will
+    // be ignored.
     ConstElementPtr config(Element::fromJSON(config_str));
     configAnswerCheck(server.updateConfig(config), false);
     EXPECT_EQ(0, server.getRootAddresses().size());
 
+    // On startup the other parameters will be installed anyway.
     configAnswerCheck(server.updateConfig(config, true), false);
     EXPECT_EQ(1, server.getRootAddresses().size());
 }




More information about the bind10-changes mailing list