BIND 10 trac1502, updated. 8f3f6eeff43f670d0c0f71216b87483b73d33607 [1502] revised the logic of checking equality of RR types as suggested in review

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Dec 28 19:38:18 UTC 2011


The branch, trac1502 has been updated
       via  8f3f6eeff43f670d0c0f71216b87483b73d33607 (commit)
      from  760720cb251366fe37bae4a06ce6e0e45ae02a33 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8f3f6eeff43f670d0c0f71216b87483b73d33607
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Dec 28 11:37:47 2011 -0800

    [1502] revised the logic of checking equality of RR types as suggested in review

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/xfrin/diff.py |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/xfrin/diff.py b/src/lib/python/isc/xfrin/diff.py
index f9f5d51..80fa909 100644
--- a/src/lib/python/isc/xfrin/diff.py
+++ b/src/lib/python/isc/xfrin/diff.py
@@ -166,9 +166,8 @@ class Diff:
             '''A helper routine to identify whether two RRsets are of the
             same 'type'.  For RRSIGs we should consider type covered, too.
             '''
-            if rrset1.get_type() != rrset2.get_type():
-                return False
-            if rrset1.get_type() != isc.dns.RRType.RRSIG():
+            if rrset1.get_type() != isc.dns.RRType.RRSIG() or \
+                    rrset2.get_type != isc.dns.RRType.RRSIG():
                 return rrset1.get_type() == rrset2.get_type()
             # RR type of the both RRsets is RRSIG.  Compare type covered.
             # We know they have exactly one RDATA.




More information about the bind10-changes mailing list