BIND 10 master, updated. 2ec914c9ed52fd0f22501addacb726ad193e1fed [master] Change unavailableAddress test
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Feb 1 12:40:27 UTC 2011
The branch, master has been updated
via 2ec914c9ed52fd0f22501addacb726ad193e1fed (commit)
from 7c42c6d38d63dd55462eb01037a55a40185920a3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2ec914c9ed52fd0f22501addacb726ad193e1fed
Author: Jelte Jansen <jelte at isc.org>
Date: Tue Feb 1 13:38:23 2011 +0100
[master] Change unavailableAddress test
It tried to bind to 255.255.0.0, which should fail, but doesn't on some
systems (CentOS for example). As a possible way forward, I've changed it
to 192.0.2.0, which does fail on CentOS. If this does not fail on other
systems, we should probably go for the proposed solution from #437, or
remove the test completely.
-----------------------------------------------------------------------
Summary of changes:
src/lib/asiolink/tests/asiolink_unittest.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/asiolink/tests/asiolink_unittest.cc b/src/lib/asiolink/tests/asiolink_unittest.cc
index c83c090..2f18f7d 100644
--- a/src/lib/asiolink/tests/asiolink_unittest.cc
+++ b/src/lib/asiolink/tests/asiolink_unittest.cc
@@ -154,14 +154,14 @@ TEST(IOServiceTest, unavailableAddress) {
IOService io_service;
// These addresses should generally be unavailable as a valid local
// address, although there's no guarantee in theory.
- EXPECT_THROW(DNSService(io_service, *TEST_SERVER_PORT, *"255.255.0.0", NULL, NULL, NULL), IOError);
+ EXPECT_THROW(DNSService(io_service, *TEST_SERVER_PORT, *"192.0.2.0", NULL, NULL, NULL), IOError);
// Some OSes would simply reject binding attempt for an AF_INET6 socket
// to an IPv4-mapped IPv6 address. Even if those that allow it, since
// the corresponding IPv4 address is the same as the one used in the
// AF_INET socket case above, it should at least show the same result
// as the previous one.
- EXPECT_THROW(DNSService(io_service, *TEST_SERVER_PORT, *"::ffff:255.255.0.0", NULL, NULL, NULL), IOError);
+ EXPECT_THROW(DNSService(io_service, *TEST_SERVER_PORT, *"::ffff:192.0.2.0", NULL, NULL, NULL), IOError);
}
TEST(IOServiceTest, duplicateBind_v6) {
More information about the bind10-changes
mailing list