BIND 10 trac253, updated. 67ff28d5017ac0cb38b591de079809bfe765ddd1 [trac253] fix some comments and unittest

BIND 10 source code commits bind10-changes at lists.isc.org
Sat Feb 19 02:16:54 UTC 2011


The branch, trac253 has been updated
       via  67ff28d5017ac0cb38b591de079809bfe765ddd1 (commit)
      from  3c06d0d6c0d002138ab3edbd9a6833a40de3f911 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 67ff28d5017ac0cb38b591de079809bfe765ddd1
Author: chenzhengzhang <jerry.zzpku at gmail.com>
Date:   Sat Feb 19 10:15:30 2011 +0800

    [trac253] fix some comments and unittest

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/python/messagerenderer_python.cc       |    4 ++--
 .../python/tests/messagerenderer_python_test.py    |   11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/python/messagerenderer_python.cc b/src/lib/dns/python/messagerenderer_python.cc
index eb38b1c..a00d8d4 100644
--- a/src/lib/dns/python/messagerenderer_python.cc
+++ b/src/lib/dns/python/messagerenderer_python.cc
@@ -38,7 +38,6 @@ static PyObject* MessageRenderer_getLength(s_MessageRenderer* self);
 static PyObject* MessageRenderer_isTruncated(s_MessageRenderer* self);
 static PyObject* MessageRenderer_getLengthLimit(s_MessageRenderer* self);
 static PyObject* MessageRenderer_getCompressMode(s_MessageRenderer* self);
-// TODO: set/get compressmode
 static PyObject* MessageRenderer_setTruncated(s_MessageRenderer* self);
 static PyObject* MessageRenderer_setLengthLimit(s_MessageRenderer* self, PyObject* args);
 static PyObject* MessageRenderer_setCompressMode(s_MessageRenderer* self, PyObject* args);
@@ -206,7 +205,8 @@ MessageRenderer_setCompressMode(s_MessageRenderer* self,
         Py_RETURN_NONE;
     } else {
         PyErr_SetString(PyExc_TypeError,
-                        "Message mode must be Message.PARSE or Message.RENDER");
+                        "MessageRenderer compress mode must be MessageRenderer.CASE_INSENSITIVE"
+                        "or MessageRenderer.CASE_SENSITIVE");
         return (NULL);
     }
 }
diff --git a/src/lib/dns/python/tests/messagerenderer_python_test.py b/src/lib/dns/python/tests/messagerenderer_python_test.py
index 5ca421c..544ad23 100644
--- a/src/lib/dns/python/tests/messagerenderer_python_test.py
+++ b/src/lib/dns/python/tests/messagerenderer_python_test.py
@@ -28,7 +28,7 @@ class MessageRendererTest(unittest.TestCase):
         c = RRClass("IN")
         t = RRType("A")
         ttl = RRTTL("3600")
-        
+
         message = Message(Message.RENDER)
         message.set_qid(123)
         message.set_opcode(Opcode.QUERY())
@@ -56,14 +56,14 @@ class MessageRendererTest(unittest.TestCase):
         self.message1.to_wire(self.renderer1)
         self.message2.to_wire(self.renderer2)
         self.message2.to_wire(self.renderer3)
-        
-    
+
+
     def test_messagerenderer_get_data(self):
         data1 = b'\x00{\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x07example\x03com\x00\x00\x01\x00\x01'
         self.assertEqual(data1, self.renderer1.get_data())
         data2 = b'\x00{\x84\x00\x00\x01\x00\x00\x00\x02\x00\x00\x07example\x03com\x00\x00\x01\x00\x01\xc0\x0c\x00\x01\x00\x01\x00\x00\x0e\x10\x00\x04\xc0\x00\x02b\xc0\x0c\x00\x01\x00\x01\x00\x00\x0e\x10\x00\x04\xc0\x00\x02c'
         self.assertEqual(data2, self.renderer2.get_data())
-        
+
     def test_messagerenderer_get_length(self):
         self.assertEqual(29, self.renderer1.get_length())
         self.assertEqual(61, self.renderer2.get_length())
@@ -106,6 +106,9 @@ class MessageRendererTest(unittest.TestCase):
         renderer.set_compress_mode(MessageRenderer.CASE_SENSITIVE)
         self.assertEqual(MessageRenderer.CASE_SENSITIVE,
                          renderer.get_compress_mode())
+        renderer.set_compress_mode(MessageRenderer.CASE_INSENSITIVE)
+        self.assertEqual(MessageRenderer.CASE_INSENSITIVE,
+                         renderer.get_compress_mode())
         self.assertRaises(TypeError, renderer.set_compress_mode, "wrong")
 
 if __name__ == '__main__':




More information about the bind10-changes mailing list