[svn] commit: r4167 - in /trunk/src/bin/resolver/tests: Makefile.am resolver_config_unittest.cc resolver_unittest.cc

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jan 5 15:40:50 UTC 2011


Author: jreed
Date: Wed Jan  5 15:40:50 2011
New Revision: 4167

Log:
Due to some merge problem (renamed directory and files), my
r4165 commit lost some changes from the r4133 commit.
I manually put these back in.
This was reviewed via jabber.

Modified:
    trunk/src/bin/resolver/tests/Makefile.am
    trunk/src/bin/resolver/tests/resolver_config_unittest.cc
    trunk/src/bin/resolver/tests/resolver_unittest.cc

Modified: trunk/src/bin/resolver/tests/Makefile.am
==============================================================================
--- trunk/src/bin/resolver/tests/Makefile.am (original)
+++ trunk/src/bin/resolver/tests/Makefile.am Wed Jan  5 15:40:50 2011
@@ -27,6 +27,7 @@
 run_unittests_LDFLAGS = $(AM_LDFLAGS) $(GTEST_LDFLAGS)
 run_unittests_LDADD = $(GTEST_LDADD)
 run_unittests_LDADD += $(SQLITE_LIBS)
+run_unittests_LDADD += $(top_builddir)/src/lib/testutils/libtestutils.la
 run_unittests_LDADD +=  $(top_builddir)/src/lib/datasrc/libdatasrc.la
 run_unittests_LDADD +=  $(top_builddir)/src/lib/dns/libdns++.la
 run_unittests_LDADD += $(top_builddir)/src/lib/asiolink/libasiolink.la

Modified: trunk/src/bin/resolver/tests/resolver_config_unittest.cc
==============================================================================
--- trunk/src/bin/resolver/tests/resolver_config_unittest.cc (original)
+++ trunk/src/bin/resolver/tests/resolver_config_unittest.cc Wed Jan  5 15:40:50 2011
@@ -12,10 +12,24 @@
 // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
 // PERFORMANCE OF THIS SOFTWARE.
 
-// $Id$
+#include <string>
+
+#include <gtest/gtest.h>
+
+#include <cc/data.h>
+
+#include <asiolink/asiolink.h>
 
 #include <resolver/resolver.h>
-#include <testutils/srv_unittest.h>
+
+#include <dns/tests/unittest_util.h>
+#include <testutils/srv_test.h>
+
+using namespace std;
+using namespace isc::data;
+using namespace isc::testutils;
+using namespace asiolink;
+using isc::UnitTestUtil;
 
 namespace {
 class ResolverConfig : public ::testing::Test {

Modified: trunk/src/bin/resolver/tests/resolver_unittest.cc
==============================================================================
--- trunk/src/bin/resolver/tests/resolver_unittest.cc (original)
+++ trunk/src/bin/resolver/tests/resolver_unittest.cc Wed Jan  5 15:40:50 2011
@@ -12,10 +12,15 @@
 // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
 // PERFORMANCE OF THIS SOFTWARE.
 
-// $Id$
+#include <dns/name.h>
 
 #include <resolver/resolver.h>
-#include <testutils/srv_unittest.h>
+#include <dns/tests/unittest_util.h>
+#include <testutils/srv_test.h>
+
+using namespace isc::dns;
+using namespace isc::testutils;
+using isc::UnitTestUtil;
 
 namespace {
 const char* const TEST_PORT = "53535";
@@ -23,48 +28,52 @@
 class ResolverTest : public SrvTestBase{
 protected:
     ResolverTest() : server(){}
+    virtual void processMessage() {
+        server.processMessage(*io_message, parse_message, response_obuffer,
+                              &dnsserv);
+    }
     Resolver server;
 };
 
 // Unsupported requests.  Should result in NOTIMP.
 TEST_F(ResolverTest, unsupportedRequest) {
-    UNSUPPORTED_REQUEST_TEST;
+    unsupportedRequest();
 }
 
 // Multiple questions.  Should result in FORMERR.
 TEST_F(ResolverTest, multiQuestion) {
-    MULTI_QUESTION_TEST; 
+    multiQuestion(); 
 }
 
 // Incoming data doesn't even contain the complete header.  Must be silently
 // dropped.
 TEST_F(ResolverTest, shortMessage) {
-    SHORT_MESSAGE_TEST;
+    shortMessage();
 }
 
 // Response messages.  Must be silently dropped, whether it's a valid response
 // or malformed or could otherwise cause a protocol error.
 TEST_F(ResolverTest, response) {
-    RESPONSE_TEST;
+     response();
 }
 
 // Query with a broken question
 TEST_F(ResolverTest, shortQuestion) {
-    SHORT_QUESTION_TEST;
+    shortQuestion();
 }
 
 // Query with a broken answer section
 TEST_F(ResolverTest, shortAnswer) {
-    SHORT_ANSWER_TEST;
+    shortAnswer();
 }
 
 // Query with unsupported version of EDNS.
 TEST_F(ResolverTest, ednsBadVers) {
-    EDNS_BADVERS_TEST;
+    ednsBadVers();
 }
 
 TEST_F(ResolverTest, AXFROverUDP) {
-    AXFR_OVER_UDP_TEST;
+    axfrOverUDP();
 }
 
 TEST_F(ResolverTest, AXFRFail) {




More information about the bind10-changes mailing list