BIND 10 trac534, updated. 83904ae5b53bf4a5a5436902f4be88f818db984a [trac534] updated comments about NS check in cutCallback().

BIND 10 source code commits bind10-changes at lists.isc.org
Sat Jan 29 09:12:32 UTC 2011


The branch, trac534 has been updated
       via  83904ae5b53bf4a5a5436902f4be88f818db984a (commit)
      from  4265faedd3e14e2f4afccd664df07a4e09e3ae7f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 83904ae5b53bf4a5a5436902f4be88f818db984a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Sat Jan 29 01:11:42 2011 -0800

    [trac534] updated comments about NS check in cutCallback().

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory_datasrc.cc |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory_datasrc.cc b/src/lib/datasrc/memory_datasrc.cc
index 7838171..ae09a3e 100644
--- a/src/lib/datasrc/memory_datasrc.cc
+++ b/src/lib/datasrc/memory_datasrc.cc
@@ -230,10 +230,12 @@ struct MemoryZone::MemoryZoneImpl {
         const Domain::const_iterator foundNS(node.getData()->find(
             RRType::NS()));
         if (foundNS != node.getData()->end()) {
-            // BIND 9 checks if this node is not the origin.  But it cannot
-            // be the origin because we don't enable the callback at the
-            // origin node (see MemoryZoneImpl::add()).  Or should we do a
-            // double check for it?
+            // BIND 9 checks if this node is not the origin.  That's probably
+            // because it can support multiple versions for dynamic updates
+            // and IXFR, and it's possible that the callback is called at
+            // the apex and the DNAME doesn't exist for a particular version.
+            // It cannot happen for us (at least for now), so we don't do
+            // that check.
             state->zonecut_node_ = &node;
             state->rrset_ = foundNS->second;
 




More information about the bind10-changes mailing list