BIND 10 trac977, updated. 4ab86cf2cd1a3133f8a5e1dd529104cb641b2ac8 [trac977] Comments about exceptions

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Jun 9 12:23:27 UTC 2011


The branch, trac977 has been updated
       via  4ab86cf2cd1a3133f8a5e1dd529104cb641b2ac8 (commit)
      from  cc5c0e24296cd58e1d6b04198da3e99af2c3071d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4ab86cf2cd1a3133f8a5e1dd529104cb641b2ac8
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Thu Jun 9 14:22:17 2011 +0200

    [trac977] Comments about exceptions

-----------------------------------------------------------------------

Summary of changes:
 src/lib/acl/check.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/acl/check.h b/src/lib/acl/check.h
index 26224c8..6175b0e 100644
--- a/src/lib/acl/check.h
+++ b/src/lib/acl/check.h
@@ -52,6 +52,12 @@ public:
      * will reimplement it and decide based on the context passed if it
      * matches.
      *
+     * The caller should expect this method can throw. The list of exceptions
+     * isn't restricted, as we don't know what kind of checks will be needed.
+     * An exception should be considered as it is impossible to check the
+     * condition. It should lead to either blackholing the packet or returning
+     * some 500-like error (ServFail).
+     *
      * \param context The thing we are trying to match against this check.
      * \return true if the context satisfies the check, false otherwise.
      */
@@ -133,6 +139,9 @@ public:
      * ownership. Therefore the only thing the caller needs to do is to make
      * sure this check is not deleted while it's still using the ones from the
      * result.
+     *
+     * This method must not throw except for the standard allocation exceptions
+     * to allocate the result.
      */
     virtual Checks getSubexpressions() const = 0;
 




More information about the bind10-changes mailing list