BIND 10 trac955, updated. 99785047d78bc833643292c1b795ea24e7916641 [trac955] added some descriptive comments to __match_exception()
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Jun 10 07:06:56 UTC 2011
The branch, trac955 has been updated
via 99785047d78bc833643292c1b795ea24e7916641 (commit)
via 6135be8219f25c87c5a551354b889e8c4e55fbfa (commit)
from 2636154f904f6123de434503ff72e65e4a27cbae (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 99785047d78bc833643292c1b795ea24e7916641
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Fri Jun 10 00:06:40 2011 -0700
[trac955] added some descriptive comments to __match_exception()
commit 6135be8219f25c87c5a551354b889e8c4e55fbfa
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Fri Jun 10 00:06:10 2011 -0700
[trac955] editorial cleanup: removed a redundant white space
(not directly related to this branch but just happen to notice it)
-----------------------------------------------------------------------
Summary of changes:
src/bin/xfrin/tests/xfrin_test.py | 4 ++++
src/bin/xfrin/xfrin.py.in | 2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/xfrin/tests/xfrin_test.py b/src/bin/xfrin/tests/xfrin_test.py
index 94fbdaa..2acd9d6 100644
--- a/src/bin/xfrin/tests/xfrin_test.py
+++ b/src/bin/xfrin/tests/xfrin_test.py
@@ -209,6 +209,10 @@ class TestXfrinConnection(unittest.TestCase):
return mock_ctx
def __match_exception(self, expected_exception, expected_msg, expression):
+ # This helper method is a higher-granularity version of assertRaises().
+ # If it's not sufficient to check the exception class (e.g., when
+ # the same type of exceptions can be thrown from many places), this
+ # method can be used to check it with the exception argument.
try:
expression()
except expected_exception as ex:
diff --git a/src/bin/xfrin/xfrin.py.in b/src/bin/xfrin/xfrin.py.in
index 85e402b..a9ca0f2 100755
--- a/src/bin/xfrin/xfrin.py.in
+++ b/src/bin/xfrin/xfrin.py.in
@@ -311,7 +311,7 @@ class XfrinConnection(asyncore.dispatcher):
raise XfrinException('error response: %s' % msg_rcode.to_text())
if not msg.get_header_flag(Message.HEADERFLAG_QR):
- raise XfrinException('response is not a response ')
+ raise XfrinException('response is not a response')
if msg.get_qid() != self._query_id:
raise XfrinException('bad query id')
More information about the bind10-changes
mailing list