BIND 10 trac997, updated. 57afee5f1238e95416c1669f5099ddf956cdd932 [trac997] use camel style for methods.
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Jun 14 18:41:23 UTC 2011
The branch, trac997 has been updated
via 57afee5f1238e95416c1669f5099ddf956cdd932 (commit)
via 77f56f23863a3e8bc9034f2134a4e7e5e1e41036 (commit)
from 04890d21897fd9afb6e13a0f7dea1f2b811d6cd6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 57afee5f1238e95416c1669f5099ddf956cdd932
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Jun 14 11:41:15 2011 -0700
[trac997] use camel style for methods.
commit 77f56f23863a3e8bc9034f2134a4e7e5e1e41036
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Jun 14 11:40:57 2011 -0700
[trac997] added blank lines for readability
-----------------------------------------------------------------------
Summary of changes:
src/lib/acl/acl.h | 2 ++
src/lib/acl/tests/acl_test.cc | 12 ++++++------
2 files changed, 8 insertions(+), 6 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/acl/acl.h b/src/lib/acl/acl.h
index 56aac09..72fefa5 100644
--- a/src/lib/acl/acl.h
+++ b/src/lib/acl/acl.h
@@ -71,6 +71,7 @@ public:
*/
ACL(const Action& default_action) : default_action_(default_action)
{}
+
/**
* \brief Pointer to the check.
*
@@ -79,6 +80,7 @@ public:
* together in future).
*/
typedef boost::shared_ptr<const Check<Context> > ConstCheckPtr;
+
/**
* \brief The actual main function that decides.
*
diff --git a/src/lib/acl/tests/acl_test.cc b/src/lib/acl/tests/acl_test.cc
index 626d055..1e70b86 100644
--- a/src/lib/acl/tests/acl_test.cc
+++ b/src/lib/acl/tests/acl_test.cc
@@ -103,7 +103,7 @@ public:
TestACL acl_;
Log log_;
size_t next_check_;
- shared_ptr<Check<Log> > get_check(bool accepts) {
+ shared_ptr<Check<Log> > getCheck(bool accepts) {
return (shared_ptr<Check<Log> >(new ConstCheck(accepts,
next_check_++)));
}
@@ -126,8 +126,8 @@ TEST_F(ACLTest, emptyRule) {
* This tests the default action in case no check matches.
*/
TEST_F(ACLTest, noMatch) {
- acl_.append(get_check(false), ACCEPT);
- acl_.append(get_check(false), REJECT);
+ acl_.append(getCheck(false), ACCEPT);
+ acl_.append(getCheck(false), REJECT);
EXPECT_EQ(DROP, acl_.execute(log_));
// The first two checks were actually run (and didn't match)
log_.checkFirst(2);
@@ -138,9 +138,9 @@ TEST_F(ACLTest, noMatch) {
* value. Also checks that the others aren't run at all.
*/
TEST_F(ACLTest, firstMatch) {
- acl_.append(get_check(false), ACCEPT);
- acl_.append(get_check(true), REJECT);
- acl_.append(get_check(true), ACCEPT);
+ acl_.append(getCheck(false), ACCEPT);
+ acl_.append(getCheck(true), REJECT);
+ acl_.append(getCheck(true), ACCEPT);
EXPECT_EQ(REJECT, acl_.execute(log_));
log_.checkFirst(2);
}
More information about the bind10-changes
mailing list