BIND 10 master, updated. a56ecdca722639891e04e89d39dcb5296f85d762 Merge branch 'master' of ssh://bind10.isc.org/var/bind10/git/bind10

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Jun 28 16:34:07 UTC 2011


The branch, master has been updated
       via  a56ecdca722639891e04e89d39dcb5296f85d762 (commit)
       via  d7675f390dbfe0dd69bda3971e0fa5e4cd007b97 (commit)
      from  4a590df96a1b1d373e87f1f56edaceccb95f267d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a56ecdca722639891e04e89d39dcb5296f85d762
Merge: d7675f390dbfe0dd69bda3971e0fa5e4cd007b97 4a590df96a1b1d373e87f1f56edaceccb95f267d
Author: Jelte Jansen <jelte at isc.org>
Date:   Tue Jun 28 16:33:48 2011 +0000

    Merge branch 'master' of ssh://bind10.isc.org/var/bind10/git/bind10

commit d7675f390dbfe0dd69bda3971e0fa5e4cd007b97
Author: Jelte Jansen <jelte at isc.org>
Date:   Tue Jun 28 16:32:50 2011 +0000

    [master] Fix solaris build issue
    
    A virtual destructor was missing in src/lib/acl/loader.h
    Also added a bit of whitespace for readability

-----------------------------------------------------------------------

Summary of changes:
 src/lib/acl/loader.h |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/acl/loader.h b/src/lib/acl/loader.h
index c3400cb..6b024c9 100644
--- a/src/lib/acl/loader.h
+++ b/src/lib/acl/loader.h
@@ -59,7 +59,9 @@ public:
         BadValue(file, line, what),
         element_(element)
     {}
+
     ~ LoaderError() throw() {}
+
     /**
      * \brief Get the element.
      *
@@ -157,6 +159,7 @@ public:
         default_action_(defaultAction),
         action_loader_(actionLoader)
     {}
+
     /**
      * \brief Creator of the checks.
      *
@@ -168,6 +171,9 @@ public:
      */
     class CheckCreator {
     public:
+        /** \brief Virtual class needs virtual destructor */
+        virtual ~CheckCreator() {}
+
         /**
          * \brief List of names supported by this loader.
          *
@@ -177,6 +183,7 @@ public:
          * types of checks.
          */
         virtual std::vector<std::string> names() const = 0;
+
         /**
          * \brief Creates the check.
          *
@@ -200,6 +207,7 @@ public:
         virtual boost::shared_ptr<Check<Context> > create(
             const std::string& name, data::ConstElementPtr definition,
             const Loader<Context, Action>& loader) = 0;
+
         /**
          * \brief Is list or-abbreviation allowed?
          *
@@ -219,6 +227,7 @@ public:
             return (true);
         }
     };
+
     /**
      * \brief Register another check creator.
      *
@@ -252,6 +261,7 @@ public:
             creators_[*i] = creator;
         }
     }
+
     /**
      * \brief Load a check.
      *
@@ -282,6 +292,7 @@ public:
         // Call the internal part with extracted map
         return (loadCheck(description, map));
     }
+
     /**
      * \brief Load an ACL.
      *
@@ -332,6 +343,7 @@ public:
         }
         return (result);
     }
+
 private:
     // Some type aliases to save typing
     typedef std::map<std::string, boost::shared_ptr<CheckCreator> > Creators;
@@ -341,6 +353,7 @@ private:
     Creators creators_;
     const Action default_action_;
     const boost::function1<Action, data::ConstElementPtr> action_loader_;
+
     /**
      * \brief Internal version of loadCheck.
      *
@@ -412,6 +425,7 @@ private:
             }
         }
     }
+
     /**
      * \brief Check that always matches.
      *




More information about the bind10-changes mailing list