BIND 10 trac614, updated. ae0b20c57c48c4932b9aff2146f5d76f9eff5a90 [trac614] Comments

[BIND 10 source code commits]

The branch, trac614 has been updated
       via  ae0b20c57c48c4932b9aff2146f5d76f9eff5a90 (commit)
       via  f9152fae80f751adc95c894b872204e98504dcb8 (commit)
       via  40f87a0aa5e6b2e8f86346f181b5e1d785c36e67 (commit)
       via  3d69f66a688c09a20083a52f2a64b9327ede70c6 (commit)
      from  f79cea1f5a7ce45498a7a94cb5ed9aae6dfe1a7f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ae0b20c57c48c4932b9aff2146f5d76f9eff5a90
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Wed Mar 2 13:26:59 2011 +0100

    [trac614] Comments

commit f9152fae80f751adc95c894b872204e98504dcb8
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Wed Mar 2 13:20:33 2011 +0100

    [trac614] More portable valgrind flags

commit 40f87a0aa5e6b2e8f86346f181b5e1d785c36e67
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Wed Mar 2 13:18:32 2011 +0100

    [trac614] Update readme

commit 3d69f66a688c09a20083a52f2a64b9327ede70c6
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Mar 2 13:15:48 2011 +0100

    [trac614] Make tests_in_valgrind more portable

-----------------------------------------------------------------------

Summary of changes:
 tools/README                   |    5 +++--
 tools/tests_in_valgrind.sh     |   10 +++++-----
 tools/valgrind_test_cleaner.pl |    7 +++++++
 3 files changed, 15 insertions(+), 7 deletions(-)

-----------------------------------------------------------------------
diff --git a/tools/README b/tools/README
index a18b38a..ce8ddea 100644
--- a/tools/README
+++ b/tools/README
@@ -1,3 +1,4 @@
 The "tools" directory contains scripts for helping the BIND 10
-developers maintain the source tree. These are not intended
-to be built nor installed by the build system.
+developers with various tasks, eg. maintaining the source tree,
+running some tests. These are not intended to be built nor
+installed by the build system.
diff --git a/tools/tests_in_valgrind.sh b/tools/tests_in_valgrind.sh
index cee177f..ef0299a 100755
--- a/tools/tests_in_valgrind.sh
+++ b/tools/tests_in_valgrind.sh
@@ -22,7 +22,7 @@
 make
 
 if [ $? = 2 ] ; then
-    echo "Did you run configure? Do you call me from the top bind10 directory?" >&2
+    echo "Did you run configure? Or maybe you're running the script from the tools directory? (you need to run it from the top bind10 build directory)"
     exit 1
 fi
 
@@ -31,7 +31,7 @@ set -e
 # Some configuration
 # TODO Escape for sed, this might break
 LOGFILE="${VALGRIND_FILE:-`pwd`/valgrind.log}"
-FLAGS="${VALGRIND_FLAGS:---read-var-info=yes --leak-check=full --track-fds=yes}"
+FLAGS="${VALGRIND_FLAGS:---leak-check=full --track-fds=yes}"
 FLAGS="$FLAGS --log-file=$LOGFILE.%p"
 
 FOUND_ANY=false
@@ -39,7 +39,7 @@ FAILED=
 
 # Find all the tests (yes, doing it by a name is a nasty hack)
 # Since the while runs in a subprocess, we need to get the assignments out, done by the eval
-eval $(find . -type f -executable -name run_unittests -print | grep -v '\.libs/run_unittests$' | while read testname ; do
+eval $(find . -type f -name run_unittests -print | grep -v '\.libs/run_unittests$' | while read testname ; do
     sed -e 's#exec "#exec valgrind '"$FLAGS"' "#' "$testname" > "$testname.valgrind"
     chmod +x "$testname.valgrind"
     echo "$testname" >>"$LOGFILE"
@@ -64,12 +64,12 @@ eval $(find . -type f -executable -name run_unittests -print | grep -v '\.libs/r
     echo 'FOUND_ANY=true'
 done)
 
-if [ -n "$FAILED" ] ; then
+if test -n "$FAILED"; then
     echo "These tests failed:" >&2
     echo "$FAILED" >&2
 fi
 
 if ! $FOUND_ANY ; then
-    echo "No test was found. It is possible you configured witouth --with-gtest or you run it from wrong directory" >&2
+    echo "No test was found. It is possible you configured without --with-gtest or you run it from wrong directory" >&2
     exit 1
 fi
diff --git a/tools/valgrind_test_cleaner.pl b/tools/valgrind_test_cleaner.pl
index 5ebf297..9928e9f 100755
--- a/tools/valgrind_test_cleaner.pl
+++ b/tools/valgrind_test_cleaner.pl
@@ -14,6 +14,13 @@ use warnings;
 #
 # Of course, the rest still can contain many uninteresting entries.
 
+# Yes, it's perl even when we use python. I wrote it for myself when
+# I needed to clean the outputs and after it proved useful to me, I
+# thought it might be for others too, so I just included it. It's not
+# that we would be switching to perl. If it should grow in future to
+# include more heuristics and do something more fancy, we should probably
+# rewrite it in python instead.
+
 my ($block, $blockOK);
 
 sub endBlock(_) {