BIND 10 trac598, updated. 5e2c9a0bce13ee28a63bc1843494e88ddd02d36e [trac598] Code style fixes

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Mar 29 17:17:20 UTC 2011


The branch, trac598 has been updated
       via  5e2c9a0bce13ee28a63bc1843494e88ddd02d36e (commit)
      from  b52e19e101e1a046e983d3fd3146aa49487a93cd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5e2c9a0bce13ee28a63bc1843494e88ddd02d36e
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Tue Mar 29 19:12:29 2011 +0200

    [trac598] Code style fixes

-----------------------------------------------------------------------

Summary of changes:
 src/lib/asiolink/io_fetch.cc        |   14 +++++++-------
 src/lib/asiolink/recursive_query.cc |   15 +++++++--------
 2 files changed, 14 insertions(+), 15 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/asiolink/io_fetch.cc b/src/lib/asiolink/io_fetch.cc
index 285a464..d670408 100644
--- a/src/lib/asiolink/io_fetch.cc
+++ b/src/lib/asiolink/io_fetch.cc
@@ -63,9 +63,9 @@ namespace asiolink {
 
 void
 IOFetch::initIOFetch(MessagePtr& query_msg, int protocol, IOService& service,
-                     const isc::dns::Question& question, const IOAddress& address,
-                     uint16_t port, isc::dns::OutputBufferPtr& buff, 
-                     Callback* cb, int wait)
+                     const isc::dns::Question& question,
+                     const IOAddress& address, uint16_t port,
+                     isc::dns::OutputBufferPtr& buff, Callback* cb, int wait)
 {
     query_msg->setQid(QidGenerator::getInstance().generateQid());
     query_msg->setOpcode(Opcode::QUERY());
@@ -78,8 +78,8 @@ IOFetch::initIOFetch(MessagePtr& query_msg, int protocol, IOService& service,
 }
 
 IOFetch::IOFetch(int protocol, IOService& service,
-    const isc::dns::Question& question, const IOAddress& address, uint16_t port,
-    isc::dns::OutputBufferPtr& buff, Callback* cb, int wait)
+    const isc::dns::Question& question, const IOAddress& address,
+    uint16_t port, isc::dns::OutputBufferPtr& buff, Callback* cb, int wait)
 {
     MessagePtr query_msg(new Message(Message::RENDER));
     initIOFetch(query_msg, protocol, service, question, address, port, buff,
@@ -154,8 +154,8 @@ IOFetch::operator()(error_code ec, size_t length) {
         }
 
         while (true) {
-            // Begin an asynchronous send, and then yield.  When the send completes
-            // send completes, we will resume immediately after this point.
+            // Begin an asynchronous send, and then yield.  When the send completes,
+            // we will resume immediately after this point.
             CORO_YIELD data_->socket->asyncSend(data_->msgbuf->getData(),
                 data_->msgbuf->getLength(), data_->remote.get(), *this);
 
diff --git a/src/lib/asiolink/recursive_query.cc b/src/lib/asiolink/recursive_query.cc
index 9a069b3..55aec7a 100644
--- a/src/lib/asiolink/recursive_query.cc
+++ b/src/lib/asiolink/recursive_query.cc
@@ -284,7 +284,7 @@ private:
         dlog("[FATAL] unreachable code");
         return true;
     }
-    
+
 public:
     RunningQuery(IOService& io,
         const Question &question,
@@ -319,14 +319,15 @@ public:
                 boost::posix_time::milliseconds(lookup_timeout));
             lookup_timer.async_wait(boost::bind(&RunningQuery::stop, this, false));
         }
-        
+
         // Setup the timer to send an answer (client_timeout)
         if (client_timeout >= 0) {
             client_timer.expires_from_now(
                 boost::posix_time::milliseconds(client_timeout));
             client_timer.async_wait(boost::bind(&RunningQuery::clientTimeout, this));
         }
-        
+
+        // should use NSAS for root servers
         setZoneServersToRoot();
         doLookup();
     }
@@ -337,7 +338,7 @@ public:
             zone_servers_.push_back(addr_t("192.5.5.241", 53));
         } else {
             // copy the list
-            dlog("Size is " + 
+            dlog("Size is " +
                 boost::lexical_cast<std::string>(upstream_root_->size()) + 
                 "\n");
             for(AddressVector::iterator it = upstream_root_->begin();
@@ -464,15 +465,13 @@ private:
     // This is where we build and store our final answer
     MessagePtr answer_message_;
 
-    // currently we use upstream as the current list of NS records
-    // we should differentiate between forwarding and resolving
+    // List of nameservers to forward to
     boost::shared_ptr<AddressVector> upstream_;
 
     // Buffer to store the result.
     OutputBufferPtr buffer_;
 
-    // Server to notify when we succeed or fail
-    //shared_ptr<DNSServer> server_;
+    // This will be notified when we succeed or fail
     isc::resolve::ResolverInterface::CallbackPtr resolvercallback_;
 
     /*




More information about the bind10-changes mailing list