BIND 10 trac743, updated. e93cfe3f6812d8a1fef103e34d9d1a6ee88dd8d7 [trac743] addressed review comments

BIND 10 source code commits bind10-changes at lists.isc.org
Thu May 12 08:09:38 UTC 2011


The branch, trac743 has been updated
       via  e93cfe3f6812d8a1fef103e34d9d1a6ee88dd8d7 (commit)
      from  f5278f2ac4becb33b93dc4c2fa7e6558a7daad8f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e93cfe3f6812d8a1fef103e34d9d1a6ee88dd8d7
Author: Jelte Jansen <jelte at isc.org>
Date:   Thu May 12 09:55:45 2011 +0200

    [trac743] addressed review comments

-----------------------------------------------------------------------

Summary of changes:
 src/lib/config/config_log.h  |   19 ++-----------------
 src/lib/config/configdef.mes |    8 ++++----
 2 files changed, 6 insertions(+), 21 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/config/config_log.h b/src/lib/config/config_log.h
index caaca7c..22e5a5c 100644
--- a/src/lib/config/config_log.h
+++ b/src/lib/config/config_log.h
@@ -23,29 +23,14 @@ namespace config {
 
 /// \brief Config Logging
 ///
-/// Defines the levels used to output debug messages in the CONFIG.  Note that
-/// higher numbers equate to more verbose (and detailed) output.
-
-// The first level traces normal operations - asking the CONFIG for an address,
-// and cancelling a lookup.  It also records when the CONFIG calls back to the
-// resolver to resolve something.
-//const int CONFIG_DBG_TRACE = 10;
-
-// The next level extends the normal operations and records the results of the
-// lookups.
-//const int CONFIG_DBG_RESULTS = 20;
-
-// Additional information on the usage of the names - the RTT values obtained
-// when queries were done.
-//const int CONFIG_DBG_RTT = 30;
-
+/// Defines logger object for config log messages
 
 /// \brief Config Logger
 ///
 /// Define the logger used to log messages.  We could define it in multiple
 /// modules, but defining in a single module and linking to it saves time and
 /// space.
-extern isc::log::Logger config_logger;    // isc::config::logger is the CONFIG logger
+extern isc::log::Logger config_logger;    // isc::config::config_logger is the CONFIG logger
 
 } // namespace config
 } // namespace isc
diff --git a/src/lib/config/configdef.mes b/src/lib/config/configdef.mes
index fe7f964..4c3c991 100644
--- a/src/lib/config/configdef.mes
+++ b/src/lib/config/configdef.mes
@@ -23,26 +23,26 @@ There was a parse error in the JSON file. The given file does not appear
 to be in valid JSON format. Please verify that the filename is correct
 and that the contents are valid JSON.
 
-% MODULE_SPEC   Module specification error in %1: %2
+% MODULE_SPEC   module specification error in %1: %2
 The given file does not appear to be a valid specification file. Please
 verify that the filename is correct and that its contents are a valid
 BIND10 module specification.
 
-% MANAGER_MOD_SPEC    Module specification not accepted by cfgmgr: %1
+% MANAGER_MOD_SPEC    module specification not accepted by cfgmgr: %1
 The module specification file for this module was rejected by the
 configuration manager. The full error message answer from the
 configuration manager is appended to the log error. The most likely
 cause is that the module is of a different (specification file) version
 than the running configuration manager.
 
-% MANAGER_CONFIG    Error getting configuration from cfgmgr: %1
+% MANAGER_CONFIG    error getting configuration from cfgmgr: %1
 The configuration manager returned an error when this module requested
 the configuration. The full error message answer from the configuration
 manager is appended to the log error. The most likely cause is that
 the module is of a different (command specification) version than the
 running configuration manager.
 
-% CCSESSION_MSG Error in CC session message: %1
+% CCSESSION_MSG error in CC session message: %1
 There was a problem with an incoming message on the command and control
 channel. The message does not appear to be a valid command, and is
 missing a required element or contains an unknown data format. This




More information about the bind10-changes mailing list