BIND 10 trac931, updated. 34b3314590c1af3c6aaf723fc29a08133fb853dd [trac931] trivial suggested changes: - typo in comment - test NULL explicitly - constify

BIND 10 source code commits bind10-changes at lists.isc.org
Wed May 18 21:55:29 UTC 2011


The branch, trac931 has been updated
       via  34b3314590c1af3c6aaf723fc29a08133fb853dd (commit)
      from  f8e2bf68f643abc26b6f6dd2613b3ef0c2dc4a73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 34b3314590c1af3c6aaf723fc29a08133fb853dd
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed May 18 14:51:47 2011 -0700

    [trac931] trivial suggested changes:
    - typo in comment
    - test NULL explicitly
    - constify

-----------------------------------------------------------------------

Summary of changes:
 src/bin/auth/auth_srv.cc                |    2 +-
 src/bin/auth/tests/auth_srv_unittest.cc |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/auth/auth_srv.cc b/src/bin/auth/auth_srv.cc
index 0e0c666..457497f 100644
--- a/src/bin/auth/auth_srv.cc
+++ b/src/bin/auth/auth_srv.cc
@@ -467,7 +467,7 @@ AuthSrv::processMessage(const IOMessage& io_message, MessagePtr message,
 
     // Do we do TSIG?
     // The keyring can be null if we're in test
-    if (server_common::keyring && tsig_record) {
+    if (server_common::keyring != NULL && tsig_record != NULL) {
         tsig_context.reset(new TSIGContext(tsig_record->getName(),
                                            tsig_record->getRdata().
                                                 getAlgorithm(),
diff --git a/src/bin/auth/tests/auth_srv_unittest.cc b/src/bin/auth/tests/auth_srv_unittest.cc
index 21592f8..a7d3ce4 100644
--- a/src/bin/auth/tests/auth_srv_unittest.cc
+++ b/src/bin/auth/tests/auth_srv_unittest.cc
@@ -248,13 +248,13 @@ TEST_F(AuthSrvTest, AXFRSuccess) {
 // well
 TEST_F(AuthSrvTest, TSIGSigned) {
     // Prepare key, the client message, etc
-    TSIGKey key("key:c2VjcmV0Cg==:hmac-sha1");
+    const TSIGKey key("key:c2VjcmV0Cg==:hmac-sha1");
     TSIGContext context(key);
     UnitTestUtil::createRequestMessage(request_message, opcode, default_qid,
                          Name("version.bind"), RRClass::CH(), RRType::TXT());
     createRequestPacket(request_message, IPPROTO_UDP, &context);
 
-    // Run the message trough the server
+    // Run the message through the server
     isc::server_common::keyring.reset(new TSIGKeyRing);
     isc::server_common::keyring->add(key);
     server.processMessage(*io_message, parse_message, response_obuffer,




More information about the bind10-changes mailing list