BIND 10 trac213-incremental-restarts, updated. 0428f6fcc7b5acc73f70913a17bd6f23c5a6ad3a [1365] added documentation about why SockCreator.__creator shhouldn't be removed.

[BIND 10 source code commits]

The branch, trac213-incremental-restarts has been updated
       via  0428f6fcc7b5acc73f70913a17bd6f23c5a6ad3a (commit)
      from  a3fd03e16b71ae4e9b480e4e48c7ddfa393555ac (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0428f6fcc7b5acc73f70913a17bd6f23c5a6ad3a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Nov 2 16:50:27 2011 -0700

    [1365] added documentation about why SockCreator.__creator shhouldn't be removed.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/bind10/sockcreator.py       |    3 +++
 src/lib/python/isc/bind10/special_component.py |    5 +++++
 2 files changed, 8 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/bind10/sockcreator.py b/src/lib/python/isc/bind10/sockcreator.py
index ecafe89..ff29f3f 100644
--- a/src/lib/python/isc/bind10/sockcreator.py
+++ b/src/lib/python/isc/bind10/sockcreator.py
@@ -201,6 +201,9 @@ class WrappedSocket:
 class Creator(Parser):
     """
     This starts the socket creator and allows asking for the sockets.
+
+    Note: __process shouldn't be reset once created.  See the note
+    of the SockCreator class for details.
     """
     def __init__(self, path):
         (local, remote) = socket.socketpair(socket.AF_UNIX, socket.SOCK_STREAM)
diff --git a/src/lib/python/isc/bind10/special_component.py b/src/lib/python/isc/bind10/special_component.py
index 156d0a9..ecdc282 100644
--- a/src/lib/python/isc/bind10/special_component.py
+++ b/src/lib/python/isc/bind10/special_component.py
@@ -22,6 +22,11 @@ class SockCreator(Component):
     """
     The socket creator component. Will start and stop the socket creator
     accordingly.
+
+    Note: _creator shouldn't be reset explicitly once created.  The
+    underlying Popen object would then wait() the child process internally,
+    which breaks the assumption of the boss, who is expecting to see
+    the process die in waitpid().
     """
     def __init__(self, process, boss, kind, address=None, params=None):
         Component.__init__(self, process, boss, kind)